<div dir="ltr">Phab is acting funny, so email comments it is.<div><br></div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
+++ include/llvm/IR/CallingConv.h<br>@@ -119,8 +119,17 @@<br>     SPIR_KERNEL = 76,<br> <br>     /// Intel_OCL_BI - Calling conventions for Intel OpenCL built-ins<br>-    Intel_OCL_BI = 77<br>+    Intel_OCL_BI = 77,<br> <br>
+    /// \brief The C convention as implemented under x86-64 on most non-<br>+    /// Windows systems.<br>+    X86_64_C = 78,</blockquote></div><div style><br></div><div style>Something like "X86_64_SysV" is probably more appropriate, since that's what everyone is trying to conform to.</div>
<div style><br></div><div style><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">+++ lib/AsmParser/LLLexer.cpp<br>
@@ -556,6 +556,8 @@<br>   KEYWORD(spir_kernel);<br>   KEYWORD(spir_func);<br>   KEYWORD(intel_ocl_bicc);<br>+  KEYWORD(x86_64_ccc);</blockquote><div><br></div></div><div style>Probably "x86_64_sysv_cc".</div><div style>
<br></div><div style><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">+++ lib/Target/X86/X86FastISel.cpp<br>
@@ -717,10 +717,11 @@<br>   CallingConv::ID CC = F.getCallingConv();<br>   if (CC != CallingConv::C &&<br>       CC != CallingConv::Fast &&<br>-      CC != CallingConv::X86_FastCall)<br>+      CC != CallingConv::X86_FastCall &&<br>
+      CC != CallingConv::X86_64_C)<br>     return false;<br> <br>-  if (Subtarget->isTargetWin64())<br>+  if (Subtarget->isTargetWin64() && CC != CallingConv::X86_64_C)</blockquote><div><br></div><div style>
I would rewrite these and all subsequent checks as a call to a helper named something like X86Subtarget::isCCWin64(CallingConv::ID).</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jul 3, 2013 at 9:40 PM, Charles Davis <span dir="ltr"><<a href="mailto:cdavis5x@gmail.com" target="_blank">cdavis5x@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
  Adding Reid at Chandler's request.<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D729" target="_blank">http://llvm-reviews.chandlerc.com/D729</a><br>
</blockquote></div><br></div>