<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Quick typing got the better of me before. ; ).<div><br></div><div>Michael</div><div><br><div><div>On Jul 5, 2013, at 2:15 PM, Eli Friedman <<a href="mailto:eli.friedman@gmail.com">eli.friedman@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr">On Fri, Jul 5, 2013 at 2:07 PM, Jordan Rose<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;">Just looking at this now: shouldn't the end-of-string check come before we try to read the character? <div class="im"><div><br></div><div><div style="margin: 0px; font-size: 11px; font-family: Menlo; color: rgb(76, 47, 45); background-color: rgb(223, 219, 196);">+ if (decDigitValue(*D.firstSigDigit) >= 10U || D.firstSigDigit == str.end()) {</div></div><div><br></div></div><div>If the string is on the end of a page, this could still crash.</div><span class=""><font color="#888888"><div></div></font></span></div></blockquote></div></div><div class="gmail_extra"><br></div><div class="gmail_extra"><span style="font-family: arial, sans-serif; font-size: 13px;">r185437.</span></div><div class="gmail_extra"><span style="font-family: arial, sans-serif; font-size: 13px;"><br></span></div><div class="gmail_extra"><span style="font-family: arial, sans-serif; font-size: 13px;">-Eli</span></div></div></div></blockquote></div><br></div></body></html>