<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jul 4, 2013 at 5:03 PM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Unless I am mistaken, this commit has the DataTypes.h.cmake file using int for 32 bit Windows while the <a href="http://DataTypes.h.in" target="_blank">DataTypes.h.in</a> file used long. For consistency, we should use long to match what msdn specifies.<br>
</blockquote><div><br></div><div style>agreed, maybe the int was introduced by mistake, long is the one we should use for consistency.</div><div style><br></div><div style>David </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
Sent from my iPhone<br>
<div class="HOEnZb"><div class="h5"><br>
On Jul 4, 2013, at 7:12 AM, Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:<br>
<br>
> Author: aaronballman<br>
> Date: Thu Jul  4 09:12:25 2013<br>
> New Revision: 185627<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=185627&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=185627&view=rev</a><br>
> Log:<br>
> Supporting ssize_t on WIN64 with its proper size.  Patch thanks to David Cournapeau!<br>
><br>
> Modified:<br>
>    llvm/trunk/include/llvm/Support/DataTypes.h.cmake<br>
>    llvm/trunk/include/llvm/Support/<a href="http://DataTypes.h.in" target="_blank">DataTypes.h.in</a><br>
><br>
> Modified: llvm/trunk/include/llvm/Support/DataTypes.h.cmake<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/DataTypes.h.cmake?rev=185627&r1=185626&r2=185627&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/DataTypes.h.cmake?rev=185627&r1=185626&r2=185627&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/include/llvm/Support/DataTypes.h.cmake (original)<br>
> +++ llvm/trunk/include/llvm/Support/DataTypes.h.cmake Thu Jul  4 09:12:25 2013<br>
> @@ -101,7 +101,11 @@ typedef short int16_t;<br>
> typedef unsigned short uint16_t;<br>
> typedef signed char int8_t;<br>
> typedef unsigned char uint8_t;<br>
> -typedef signed int ssize_t;<br>
> +#if defined(_WIN64)<br>
> +  typedef signed __int64 ssize_t;<br>
> +#else<br>
> +  typedef signed int ssize_t;<br>
> +#endif<br>
> #ifndef INT8_MAX<br>
> # define INT8_MAX 127<br>
> #endif<br>
><br>
> Modified: llvm/trunk/include/llvm/Support/<a href="http://DataTypes.h.in" target="_blank">DataTypes.h.in</a><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/DataTypes.h.in?rev=185627&r1=185626&r2=185627&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/DataTypes.h.in?rev=185627&r1=185626&r2=185627&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/include/llvm/Support/<a href="http://DataTypes.h.in" target="_blank">DataTypes.h.in</a> (original)<br>
> +++ llvm/trunk/include/llvm/Support/<a href="http://DataTypes.h.in" target="_blank">DataTypes.h.in</a> Thu Jul  4 09:12:25 2013<br>
> @@ -98,7 +98,12 @@ typedef short int16_t;<br>
> typedef unsigned short uint16_t;<br>
> typedef signed char int8_t;<br>
> typedef unsigned char uint8_t;<br>
> -typedef signed int ssize_t;<br>
> +#if defined(_WIN64)<br>
> +  typedef signed __int64 ssize_t;<br>
> +#else<br>
> +  typedef signed long ssize_t;<br>
> +#endif<br>
> +<br>
> #ifndef INT8_MAX<br>
> # define INT8_MAX 127<br>
> #endif<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>blog: <a href="http://cournape.wordpress.com" target="_blank">http://cournape.wordpress.com</a><div>code: <a href="https://github.com/cournape" target="_blank">https://github.com/cournape</a></div>
<div>twitter: @cournape</div>
</div></div>