<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 02/07/13 13:51, Robert Lytton wrote:<br>
</div>
<blockquote
cite="mid:E55040AE4CA5DE4A84D2754CE295AF30DF378A@EXMAILBOX1.vo.spidergroup.co.uk"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;</style><br>
<div style="direction: ltr;font-family: Tahoma;color:
#000000;font-size: 10pt;">
--- /dev/null<br>
+++ llvm/test/CodeGen/XCore/zext.ll<br>
@@ -0,0 +1,17 @@<br>
+; RUN: llc -march=xcore < %s | FileCheck %s<br>
+;; countLeadingZeros() must be past 32bit types<br>
+<br>
+define i32 @f(i1 %a) {<br>
+entry:<br>
+; CHECK: zext r0, 1<br>
+; CHECK: retsp 0<br>
+ %b= zext i1 %a to i32<br>
+ ret i32 %b<br>
+}<br>
</div>
</blockquote>
Typically FileCheck tests check for the function label (e.g. CHECK:
f:) so subsequent checks don't inadvertently match instruction
sequences in other functions.<br>
<blockquote
cite="mid:E55040AE4CA5DE4A84D2754CE295AF30DF378A@EXMAILBOX1.vo.spidergroup.co.uk"
type="cite">
<div style="direction: ltr;font-family: Tahoma;color:
#000000;font-size: 10pt;">
+<br>
+define i32 @g() {<br>
+entry:<br>
+; CHECK: mkmsk r0, 1<br>
+; CHECK: retsp 0<br>
+ ret i32 1;<br>
+}<br>
<br>
</div>
</blockquote>
This should go in test/CodeGen/XCore/constants.ll (since it relates
to forming constants).<br>
<br>
Otherwise it looks good to me. I've applied the patch with these
changes in r185430<br>
<br>
<pre class="moz-signature" cols="72">--
Richard Osborne | XMOS
<a class="moz-txt-link-freetext" href="http://www.xmos.com">http://www.xmos.com</a>
</pre>
</body>
</html>