<div dir="ltr">That would imply that PBQP was less than eternally perfect.<div><br></div><div>Actually we tend to test register allocators with the test suite, rather than regression tests. Of course we don't have a PBQP nightly tester either... I'll work on that.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 1, 2013 at 2:09 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Mon, Jul 1, 2013 at 1:47 PM, Lang Hames <<a href="mailto:lhames@gmail.com">lhames@gmail.com</a>> wrote:<br>

> Author: lhames<br>
> Date: Mon Jul  1 15:47:47 2013<br>
> New Revision: 185378<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=185378&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=185378&view=rev</a><br>
> Log:<br>
> Make PBQP require/preserve MachineLoopInfo - the spiller requires it.<br>
<br>
</div>Test case?<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> Modified:<br>
>     llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp<br>
><br>
> Modified: llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp?rev=185378&r1=185377&r2=185378&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp?rev=185378&r1=185377&r2=185378&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp (original)<br>
> +++ llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp Mon Jul  1 15:47:47 2013<br>
> @@ -43,6 +43,7 @@<br>
>  #include "llvm/CodeGen/MachineBlockFrequencyInfo.h"<br>
>  #include "llvm/CodeGen/MachineDominators.h"<br>
>  #include "llvm/CodeGen/MachineFunctionPass.h"<br>
> +#include "llvm/CodeGen/MachineLoopInfo.h"<br>
>  #include "llvm/CodeGen/MachineRegisterInfo.h"<br>
>  #include "llvm/CodeGen/PBQP/Graph.h"<br>
>  #include "llvm/CodeGen/PBQP/HeuristicSolver.h"<br>
> @@ -436,6 +437,8 @@ void RegAllocPBQP::getAnalysisUsage(Anal<br>
>    au.addPreserved<LiveStacks>();<br>
>    au.addRequired<MachineBlockFrequencyInfo>();<br>
>    au.addPreserved<MachineBlockFrequencyInfo>();<br>
> +  au.addRequired<MachineLoopInfo>();<br>
> +  au.addPreserved<MachineLoopInfo>();<br>
>    au.addRequired<MachineDominatorTree>();<br>
>    au.addPreserved<MachineDominatorTree>();<br>
>    au.addRequired<VirtRegMap>();<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>