<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Tim,<div><br></div><div>The patch LGTM with one question:</div><div>Do you have any performance number to see the impact of this patch?</div><div><br></div><div>Indeed, tail calls are generally faster, but I am wondering why it was not enabled for non-iOS targets before your patch. Hence, having some evidences that it does not have weird side effects would be nice.</div><div><br></div><div>Thanks,</div><div><br></div><div><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div><div>On Jun 30, 2013, at 3:12 AM, Tim Northover <<a href="mailto:t.p.northover@gmail.com">t.p.northover@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hi,<br><br>The attached patch enables tail calls for every target that hasn't<br>explicitly been marked as bad (iOS < 5.0). This amounts to any ELF<br>target and being more liberal on some ghost MachO targets (e.g.<br>arm-apple-darwin9) that no-one probably cares about.<br><br>I think the ELF side is justified because the required linker support<br>is there in the ARM ELF specification so anywhere it doesn't work has<br>a broken linker. I've also tested it on Linux and our MCJIT dynamic<br>loader with no issues.<br><br>Does anyone object to the change?<br><br>Cheers.<br><br>Tim.<br><span><enable-tail.diff></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></body></html>