<div dir="ltr">On Fri, Jun 28, 2013 at 3:04 PM, Hal Finkel <span dir="ltr"><<a href="mailto:hfinkel@anl.gov" target="_blank">hfinkel@anl.gov</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">----- Original Message -----<br>
> Author: rtrieu<br>
> Date: Fri Jun 28 16:54:25 2013<br>
> New Revision: 185227<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=185227&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=185227&view=rev</a><br>
> Log:<br>
> Fix broken asserts that never fire.<br>
><br>
> Change assert("text") to assert(0 && "text").  The first case is a<br>
> const char *<br>
> to bool conversion, which always evaluates to true, never triggering<br>
> the<br>
> assert.  The second case will always trigger the assert.<br>
<br>
</div>Please use llvm_unreachable for all of these.<br>
<br>
 -Hal<br></blockquote><div><br></div><div>Is that the preferred method now?  The codebase has many examples of assert(0 && "text"); </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class="im HOEnZb"><br>
><br>
> Modified:<br>
>     llvm/trunk/include/llvm/TableGen/Record.h<br>
>     llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp<br>
><br>
> Modified: llvm/trunk/include/llvm/TableGen/Record.h<br>
> URL:<br>
> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/TableGen/Record.h?rev=185227&r1=185226&r2=185227&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/TableGen/Record.h?rev=185227&r1=185226&r2=185227&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/include/llvm/TableGen/Record.h (original)<br>
> +++ llvm/trunk/include/llvm/TableGen/Record.h Fri Jun 28 16:54:25<br>
> 2013<br>
> @@ -1799,9 +1799,9 @@ struct LessRecordRegister {<br>
><br>
>        unsigned LHSVal, RHSVal;<br>
>        if (LHSPart.second.getAsInteger(10, LHSVal))<br>
> -        assert("Unable to convert LHS to integer.");<br>
> +        assert(0 && "Unable to convert LHS to integer.");<br>
>        if (RHSPart.second.getAsInteger(10, RHSVal))<br>
> -        assert("Unable to convert RHS to integer.");<br>
> +        assert(0 && "Unable to convert RHS to integer.");<br>
</div><div class="HOEnZb"><div class="h5">>        if (LHSVal != RHSVal)<br>
>          return LHSVal < RHSVal;<br>
>      }<br>
><br>
> Modified:<br>
> llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp<br>
> URL:<br>
> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp?rev=185227&r1=185226&r2=185227&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp?rev=185227&r1=185226&r2=185227&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp<br>
> (original)<br>
> +++ llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp<br>
> Fri Jun 28 16:54:25 2013<br>
> @@ -179,7 +179,7 @@ void HexagonInstPrinter::printBranchOper<br>
>                                              raw_ostream &O) const {<br>
>    // Branches can take an immediate operand.  This is used by the<br>
>    branch<br>
>    // selection pass to print $+8, an eight byte displacement from<br>
>    the PC.<br>
> -  assert("Unknown branch operand.");<br>
> +  assert(0 && "Unknown branch operand.");<br>
>  }<br>
><br>
>  void HexagonInstPrinter::printCallOperand(const MCInst *MI, unsigned<br>
>  OpNo,<br>
> @@ -203,7 +203,7 @@ void HexagonInstPrinter::printSymbol(con<br>
>      O << '#';<br>
>      printOperand(MI, OpNo, O);<br>
>    } else {<br>
> -    assert("Unknown symbol operand");<br>
> +    assert(0 && "Unknown symbol operand");<br>
>      printOperand(MI, OpNo, O);<br>
>    }<br>
</div></div><div class="HOEnZb"><div class="h5">>    O << ')';<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Hal Finkel<br>
Assistant Computational Scientist<br>
Leadership Computing Facility<br>
Argonne National Laboratory<br>
</font></span></blockquote></div><br></div></div>