<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 25, 2013 at 9:09 PM, Dmitry Vyukov <span dir="ltr"><<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">There are still some moments that are unclear to me:<br>
1. Is INTERCEPTOR_ATTRIBUTE part of public interface of interceptor library?<br>
2. Will it preserve it's meaning over time? It looks like an<br>
implementation detail of interceptor machinery.</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
3. We do not intercept operator new/delete as interception library<br>
does (i.e. hot patching function prologue). We just define our own<br>
versions. So is it the same?<br></blockquote><div><br></div><div>+glider</div><div><br></div><div>"hot patching" is not used anymore.</div><div>But, the question is interesting. It looks like we really "define" our own new/delete and want</div>
<div>to export them, so SANITIZER_INTERFACE_ATTRIBUTE is the correct macro for it.</div><div> </div><div>Interceptors on Mac doesn't have __attribute__((visibility("default"))). Should new/delete on Mac</div>
<div>have it?</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5"><br>
<br>
<br>
On Tue, Jun 25, 2013 at 8:55 PM, Sergey Matveev <<a href="mailto:earthdok@google.com">earthdok@google.com</a>> wrote:<br>
> You also have operators new and delete in this patch.<br>
><br>
> On Tue, Jun 25, 2013 at 8:40 PM, Dmitry Vyukov <<a href="mailto:dvyukov@google.com">dvyukov@google.com</a>> wrote:<br>
>><br>
>> __interceptor__setjmp() is not an interceptor, it's an interface function.<br></div></div></blockquote><div><br></div><div>Why?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5">
>><br>
>> On Tue, Jun 25, 2013 at 8:25 PM, Sergey Matveev <<a href="mailto:earthdok@google.com">earthdok@google.com</a>><br>
>> wrote:<br>
>> > Interface functions that we expose. E.g. __asan_init()<br>
>> ><br>
>> ><br>
>> > On Tue, Jun 25, 2013 at 8:20 PM, Dmitry Vyukov <<a href="mailto:dvyukov@google.com">dvyukov@google.com</a>><br>
>> > wrote:<br>
>> >><br>
>> >> What is SANITIZER_INTERFACE_ATTRIBUTE for?<br>
>> >><br>
>> >> On Tue, Jun 25, 2013 at 7:59 PM, Sergey Matveev <<a href="mailto:earthdok@google.com">earthdok@google.com</a>><br>
>> >> wrote:<br>
>> >> > On Linux at least, they expand to the same thing. But I think<br>
>> >> > interface-wise, INTERCEPTOR_ATTRIBUTE is the proper one to use here.<br>
>> >> ><br>
>> >> ><br>
>> >> > On Tue, Jun 25, 2013 at 7:54 PM, Dmitry Vyukov <<a href="mailto:dvyukov@google.com">dvyukov@google.com</a>><br>
>> >> > wrote:<br>
>> >> >><br>
>> >> >> I don't know<br>
>> >> >><br>
>> >> >> On Tue, Jun 25, 2013 at 7:43 PM, Sergey Matveev<br>
>> >> >> <<a href="mailto:earthdok@google.com">earthdok@google.com</a>><br>
>> >> >> wrote:<br>
>> >> >> > Shouldn't this be INTERCEPTOR_ATTRIBUTE?<br>
>> >> >> ><br>
>> >> >> ><br>
>> >> >> > On Tue, Jun 25, 2013 at 7:36 PM, Dmitry Vyukov<br>
>> >> >> > <<a href="mailto:dvyukov@google.com">dvyukov@google.com</a>><br>
>> >> >> > wrote:<br>
>> >> >> >><br>
>> >> >> >> Author: dvyukov<br>
>> >> >> >> Date: Tue Jun 25 10:36:25 2013<br>
>> >> >> >> New Revision: 184858<br>
>> >> >> >><br>
>> >> >> >> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=184858&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=184858&view=rev</a><br>
>> >> >> >> Log:<br>
>> >> >> >> tsan: add missing __attribute__((visibility("default"))) to<br>
>> >> >> >> interface<br>
>> >> >> >> functions<br>
>> >> >> >><br>
>> >> >> >> Modified:<br>
>> >> >> >> compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc<br>
>> >> >> >><br>
>> >> >> >> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc<br>
>> >> >> >> URL:<br>
>> >> >> >><br>
>> >> >> >><br>
>> >> >> >><br>
>> >> >> >> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc?rev=184858&r1=184857&r2=184858&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc?rev=184858&r1=184857&r2=184858&view=diff</a><br>
>> >> >> >><br>
>> >> >> >><br>
>> >> >> >><br>
>> >> >> >><br>
>> >> >> >> ==============================================================================<br>
>> >> >> >> --- compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc<br>
>> >> >> >> (original)<br>
>> >> >> >> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc Tue Jun<br>
>> >> >> >> 25<br>
>> >> >> >> 10:36:25 2013<br>
>> >> >> >> @@ -367,21 +367,29 @@ extern "C" void __tsan_setjmp(uptr sp, u<br>
>> >> >> >> }<br>
>> >> >> >><br>
>> >> >> >> // Not called. Merely to satisfy TSAN_INTERCEPT().<br>
>> >> >> >> +extern "C" int __interceptor_setjmp(void *env)<br>
>> >> >> >> + SANITIZER_INTERFACE_ATTRIBUTE;<br>
>> >> >> >> extern "C" int __interceptor_setjmp(void *env) {<br>
>> >> >> >> CHECK(0);<br>
>> >> >> >> return 0;<br>
>> >> >> >> }<br>
>> >> >> >><br>
>> >> >> >> +extern "C" int __interceptor__setjmp(void *env)<br>
>> >> >> >> + SANITIZER_INTERFACE_ATTRIBUTE;<br>
>> >> >> >> extern "C" int __interceptor__setjmp(void *env) {<br>
>> >> >> >> CHECK(0);<br>
>> >> >> >> return 0;<br>
>> >> >> >> }<br>
>> >> >> >><br>
>> >> >> >> +extern "C" int __interceptor_sigsetjmp(void *env)<br>
>> >> >> >> + SANITIZER_INTERFACE_ATTRIBUTE;<br>
>> >> >> >> extern "C" int __interceptor_sigsetjmp(void *env) {<br>
>> >> >> >> CHECK(0);<br>
>> >> >> >> return 0;<br>
>> >> >> >> }<br>
>> >> >> >><br>
>> >> >> >> +extern "C" int __interceptor___sigsetjmp(void *env)<br>
>> >> >> >> + SANITIZER_INTERFACE_ATTRIBUTE;<br>
>> >> >> >> extern "C" int __interceptor___sigsetjmp(void *env) {<br>
>> >> >> >> CHECK(0);<br>
>> >> >> >> return 0;<br>
>> >> >> >> @@ -493,15 +501,26 @@ TSAN_INTERCEPTOR(uptr, malloc_usable_siz<br>
>> >> >> >> invoke_malloc_hook(p, size); \<br>
>> >> >> >> return p;<br>
>> >> >> >><br>
>> >> >> >> +void *operator new(__sanitizer::uptr size)<br>
>> >> >> >> + SANITIZER_INTERFACE_ATTRIBUTE;<br>
>> >> >> >> void *operator new(__sanitizer::uptr size) {<br>
>> >> >> >> OPERATOR_NEW_BODY(_Znwm);<br>
>> >> >> >> }<br>
>> >> >> >> +<br>
>> >> >> >> +void *operator new[](__sanitizer::uptr size)<br>
>> >> >> >> + SANITIZER_INTERFACE_ATTRIBUTE;<br>
>> >> >> >> void *operator new[](__sanitizer::uptr size) {<br>
>> >> >> >> OPERATOR_NEW_BODY(_Znam);<br>
>> >> >> >> }<br>
>> >> >> >> +<br>
>> >> >> >> +void *operator new(__sanitizer::uptr size, std::nothrow_t<br>
>> >> >> >> const&)<br>
>> >> >> >> + SANITIZER_INTERFACE_ATTRIBUTE;<br>
>> >> >> >> void *operator new(__sanitizer::uptr size, std::nothrow_t<br>
>> >> >> >> const&) {<br>
>> >> >> >> OPERATOR_NEW_BODY(_ZnwmRKSt9nothrow_t);<br>
>> >> >> >> }<br>
>> >> >> >> +<br>
>> >> >> >> +void *operator new[](__sanitizer::uptr size, std::nothrow_t<br>
>> >> >> >> const&)<br>
>> >> >> >> + SANITIZER_INTERFACE_ATTRIBUTE;<br>
>> >> >> >> void *operator new[](__sanitizer::uptr size, std::nothrow_t<br>
>> >> >> >> const&)<br>
>> >> >> >> {<br>
>> >> >> >> OPERATOR_NEW_BODY(_ZnamRKSt9nothrow_t);<br>
>> >> >> >> }<br>
>> >> >> >> @@ -514,15 +533,26 @@ void *operator new[](__sanitizer::uptr s<br>
>> >> >> >> SCOPED_INTERCEPTOR_RAW(mangled_name, ptr); \<br>
>> >> >> >> user_free(thr, pc, ptr);<br>
>> >> >> >><br>
>> >> >> >> +void operator delete(void *ptr)<br>
>> >> >> >> + SANITIZER_INTERFACE_ATTRIBUTE;<br>
>> >> >> >> void operator delete(void *ptr) {<br>
>> >> >> >> OPERATOR_DELETE_BODY(_ZdlPv);<br>
>> >> >> >> }<br>
>> >> >> >> +<br>
>> >> >> >> +void operator delete[](void *ptr)<br>
>> >> >> >> + SANITIZER_INTERFACE_ATTRIBUTE;<br>
>> >> >> >> void operator delete[](void *ptr) {<br>
>> >> >> >> OPERATOR_DELETE_BODY(_ZdlPvRKSt9nothrow_t);<br>
>> >> >> >> }<br>
>> >> >> >> +<br>
>> >> >> >> +void operator delete(void *ptr, std::nothrow_t const&)<br>
>> >> >> >> + SANITIZER_INTERFACE_ATTRIBUTE;<br>
>> >> >> >> void operator delete(void *ptr, std::nothrow_t const&) {<br>
>> >> >> >> OPERATOR_DELETE_BODY(_ZdaPv);<br>
>> >> >> >> }<br>
>> >> >> >> +<br>
>> >> >> >> +void operator delete[](void *ptr, std::nothrow_t const&)<br>
>> >> >> >> + SANITIZER_INTERFACE_ATTRIBUTE;<br>
>> >> >> >> void operator delete[](void *ptr, std::nothrow_t const&) {<br>
>> >> >> >> OPERATOR_DELETE_BODY(_ZdaPvRKSt9nothrow_t);<br>
>> >> >> >> }<br>
>> >> >> >><br>
>> >> >> >><br>
>> >> >> >> _______________________________________________<br>
>> >> >> >> llvm-commits mailing list<br>
>> >> >> >> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> >> >> >> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
>> >> >> ><br>
>> >> >> ><br>
>> >> ><br>
>> >> ><br>
>> ><br>
>> ><br>
><br>
><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div></div>