<p dir="ltr">Yeah. No matter what that isn't the correct fix. Can you be more clear on what the symptoms you saw are and what's going on? I've been communicating with Michael since committing and was under the impression that all of them were fixed. </p>
<p dir="ltr">-eric</p>
<div class="gmail_quote">On Jun 26, 2013 11:13 PM, "Bob Wilson" <<a href="mailto:bob.wilson@apple.com">bob.wilson@apple.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">This broke one of Apple’s buildbots. I have tried to get it going again by adding CXXFLAGS back to the link command in r185060. I still need to confirm that it actually fixes the buildbot. Assuming that it does, will that work for you, Eric? It wasn’t clear from your commit message why you changed this, so I don’t know what your constraints are.<div>
<br><div><div><div>On Jun 24, 2013, at 4:20 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:</div><br><blockquote type="cite"><div style="font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
Author: echristo<br>Date: Mon Jun 24 18:20:04 2013<br>New Revision: 184793<br><br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project?rev=184793&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=184793&view=rev</a><br>
Log:<br>Remove all non-linker oriented compile options from the linker<br>command line. Change the darwin universal binary options to<br>be TargetCommonOpts so that they'll be passed to the linker since<br>-arch at least is still needed.<br>
<br>Someone on darwin with a buildit based build should probably verify<br>that this doesn't break anything there.<br><br>Modified:<br> llvm/trunk/Makefile.rules<br><br>Modified: llvm/trunk/Makefile.rules<br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/Makefile.rules?rev=184793&r1=184792&r2=184793&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/Makefile.rules?rev=184793&r1=184792&r2=184793&view=diff</a><br>
==============================================================================<br>--- llvm/trunk/Makefile.rules (original)<br>+++ llvm/trunk/Makefile.rules Mon Jun 24 18:20:04 2013<br>@@ -691,9 +691,9 @@ ifdef UNIVERSAL<br>
UNIVERSAL_ARCH := i386 ppc<br> endif<br> UNIVERSAL_ARCH_OPTIONS := $(UNIVERSAL_ARCH:%=-arch %)<br>- CompileCommonOpts += $(UNIVERSAL_ARCH_OPTIONS)<br>+ TargetCommonOpts += $(UNIVERSAL_ARCH_OPTIONS)<br> ifdef UNIVERSAL_SDK_PATH<br>
- CompileCommonOpts += -isysroot $(UNIVERSAL_SDK_PATH)<br>+ TargetCommonOpts += -isysroot $(UNIVERSAL_SDK_PATH)<br> endif<br><br> # Building universal cannot compute dependencies automatically.<br>@@ -755,8 +755,7 @@ Preprocess.CXX= $(Compile.Wrapper) \<br>
<span style="white-space:pre-wrap"> </span><span> </span> $(CXX) $(CPP.Flags) $(TargetCommonOpts) $(CPPFLAGS) \<br> $(CompileCommonOpts) $(CXX.Flags) -E<br>Link = $(Compile.Wrapper) \<br>-<span style="white-space:pre-wrap"> </span><span> </span> $(CXX) $(CPP.Flags) $(CXX.Flags) $(CXXFLAGS) $(LD.Flags) \<br>
- $(LDFLAGS) $(TargetCommonOpts) $(CompileCommonOpts) $(Strip)<br>+<span style="white-space:pre-wrap"> </span><span> </span> $(CXX) $(LD.Flags) $(LDFLAGS) $(TargetCommonOpts) $(Strip)<br><br>BCCompile.C = $(LLVMCC) $(CPP.Flags) $(C.Flags) $(CFLAGS) $(CPPFLAGS) \<br>
$(TargetCommonOpts) $(CompileCommonOpts)<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></div></div></blockquote></div>