<div dir="ltr">Shouldn't this be INTERCEPTOR_ATTRIBUTE?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 25, 2013 at 7:36 PM, Dmitry Vyukov <span dir="ltr"><<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dvyukov<br>
Date: Tue Jun 25 10:36:25 2013<br>
New Revision: 184858<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=184858&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=184858&view=rev</a><br>
Log:<br>
tsan: add missing __attribute__((visibility("default"))) to interface functions<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc<br>
<br>
Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc?rev=184858&r1=184857&r2=184858&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc?rev=184858&r1=184857&r2=184858&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc (original)<br>
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc Tue Jun 25 10:36:25 2013<br>
@@ -367,21 +367,29 @@ extern "C" void __tsan_setjmp(uptr sp, u<br>
 }<br>
<br>
 // Not called.  Merely to satisfy TSAN_INTERCEPT().<br>
+extern "C" int __interceptor_setjmp(void *env)<br>
+    SANITIZER_INTERFACE_ATTRIBUTE;<br>
 extern "C" int __interceptor_setjmp(void *env) {<br>
   CHECK(0);<br>
   return 0;<br>
 }<br>
<br>
+extern "C" int __interceptor__setjmp(void *env)<br>
+    SANITIZER_INTERFACE_ATTRIBUTE;<br>
 extern "C" int __interceptor__setjmp(void *env) {<br>
   CHECK(0);<br>
   return 0;<br>
 }<br>
<br>
+extern "C" int __interceptor_sigsetjmp(void *env)<br>
+    SANITIZER_INTERFACE_ATTRIBUTE;<br>
 extern "C" int __interceptor_sigsetjmp(void *env) {<br>
   CHECK(0);<br>
   return 0;<br>
 }<br>
<br>
+extern "C" int __interceptor___sigsetjmp(void *env)<br>
+    SANITIZER_INTERFACE_ATTRIBUTE;<br>
 extern "C" int __interceptor___sigsetjmp(void *env) {<br>
   CHECK(0);<br>
   return 0;<br>
@@ -493,15 +501,26 @@ TSAN_INTERCEPTOR(uptr, malloc_usable_siz<br>
   invoke_malloc_hook(p, size);  \<br>
   return p;<br>
<br>
+void *operator new(__sanitizer::uptr size)<br>
+    SANITIZER_INTERFACE_ATTRIBUTE;<br>
 void *operator new(__sanitizer::uptr size) {<br>
   OPERATOR_NEW_BODY(_Znwm);<br>
 }<br>
+<br>
+void *operator new[](__sanitizer::uptr size)<br>
+    SANITIZER_INTERFACE_ATTRIBUTE;<br>
 void *operator new[](__sanitizer::uptr size) {<br>
   OPERATOR_NEW_BODY(_Znam);<br>
 }<br>
+<br>
+void *operator new(__sanitizer::uptr size, std::nothrow_t const&)<br>
+    SANITIZER_INTERFACE_ATTRIBUTE;<br>
 void *operator new(__sanitizer::uptr size, std::nothrow_t const&) {<br>
   OPERATOR_NEW_BODY(_ZnwmRKSt9nothrow_t);<br>
 }<br>
+<br>
+void *operator new[](__sanitizer::uptr size, std::nothrow_t const&)<br>
+    SANITIZER_INTERFACE_ATTRIBUTE;<br>
 void *operator new[](__sanitizer::uptr size, std::nothrow_t const&) {<br>
   OPERATOR_NEW_BODY(_ZnamRKSt9nothrow_t);<br>
 }<br>
@@ -514,15 +533,26 @@ void *operator new[](__sanitizer::uptr s<br>
   SCOPED_INTERCEPTOR_RAW(mangled_name, ptr);  \<br>
   user_free(thr, pc, ptr);<br>
<br>
+void operator delete(void *ptr)<br>
+    SANITIZER_INTERFACE_ATTRIBUTE;<br>
 void operator delete(void *ptr) {<br>
   OPERATOR_DELETE_BODY(_ZdlPv);<br>
 }<br>
+<br>
+void operator delete[](void *ptr)<br>
+    SANITIZER_INTERFACE_ATTRIBUTE;<br>
 void operator delete[](void *ptr) {<br>
   OPERATOR_DELETE_BODY(_ZdlPvRKSt9nothrow_t);<br>
 }<br>
+<br>
+void operator delete(void *ptr, std::nothrow_t const&)<br>
+    SANITIZER_INTERFACE_ATTRIBUTE;<br>
 void operator delete(void *ptr, std::nothrow_t const&) {<br>
   OPERATOR_DELETE_BODY(_ZdaPv);<br>
 }<br>
+<br>
+void operator delete[](void *ptr, std::nothrow_t const&)<br>
+    SANITIZER_INTERFACE_ATTRIBUTE;<br>
 void operator delete[](void *ptr, std::nothrow_t const&) {<br>
   OPERATOR_DELETE_BODY(_ZdaPvRKSt9nothrow_t);<br>
 }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>