<div dir="ltr">Not yet, the bots haven't caught up to this one. They were broken by an earlier one. I'm actually watching the bot progress toward this one which is intended *to* fix the build.</div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Mon, Jun 24, 2013 at 6:27 PM, Kevin Enderby <span dir="ltr"><<a href="mailto:enderby@apple.com" target="_blank">enderby@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello Chandler. I believe that your commit r184805 has broken the following buildbot:<br>
<br>
    <a href="http://lab.llvm.org:8013/builders/clang-x86_64-darwin11-nobootstrap-RAincremental/builds/3444" target="_blank">http://lab.llvm.org:8013/builders/clang-x86_64-darwin11-nobootstrap-RAincremental/builds/3444</a><br>

<br>
And likely many others that are failing. Can you please fix this?<br>
<br>
Thanks,<br>
Kev (acting build czar at the moment)<br>
<div class="HOEnZb"><div class="h5"><br>
On Jun 24, 2013, at 5:57 PM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com">chandlerc@gmail.com</a>> wrote:<br>
<br>
> Author: chandlerc<br>
> Date: Mon Jun 24 19:57:06 2013<br>
> New Revision: 184805<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=184805&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=184805&view=rev</a><br>
> Log:<br>
> Remove the sysroot (or isysroot) restriction from the GCDAProfile.c<br>
> runtime in the Makefile build system as well. Sorry for the temporary<br>
> fallout, it took me a while to find these bits.<br>
><br>
> Bill, I'm not at all confident of the change for Darwin and iOS, but as<br>
> discussed we're completely blocked on fixing this. Anyways, please<br>
> review and let me know if this will work for you guys. If necessary,<br>
> I can work with you to rig up an errno.h stub for Darwin, but I expect<br>
> that to be... moderately challenging.<br>
><br>
> Modified:<br>
>    compiler-rt/trunk/make/platform/<a href="http://clang_darwin.mk" target="_blank">clang_darwin.mk</a><br>
>    compiler-rt/trunk/make/platform/<a href="http://clang_linux.mk" target="_blank">clang_linux.mk</a><br>
><br>
> Modified: compiler-rt/trunk/make/platform/<a href="http://clang_darwin.mk" target="_blank">clang_darwin.mk</a><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/make/platform/clang_darwin.mk?rev=184805&r1=184804&r2=184805&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/make/platform/clang_darwin.mk?rev=184805&r1=184804&r2=184805&view=diff</a><br>

> ==============================================================================<br>
> --- compiler-rt/trunk/make/platform/<a href="http://clang_darwin.mk" target="_blank">clang_darwin.mk</a> (original)<br>
> +++ compiler-rt/trunk/make/platform/<a href="http://clang_darwin.mk" target="_blank">clang_darwin.mk</a> Mon Jun 24 19:57:06 2013<br>
> @@ -117,6 +117,18 @@ IOS_DEPLOYMENT_ARGS := -mios-version-min<br>
> IOS6_DEPLOYMENT_ARGS := -mios-version-min=6.0<br>
> IOSSIM_DEPLOYMENT_ARGS := -mios-simulator-version-min=1.0<br>
><br>
> +# Setup the CFLAGS for the profile runtime library before narrowing the<br>
> +# deployment args to use the compiler-rt fake header sysroot as we want the<br>
> +# profile runtime to have access to basic libc routines, etc.<br>
> +CFLAGS.profile_osx.i386   := $(CFLAGS) $(OSX_DEPLOYMENT_ARGS)<br>
> +CFLAGS.profile_osx.x86_64 := $(CFLAGS) $(OSX_DEPLOYMENT_ARGS)<br>
> +CFLAGS.profile_ios.i386   := $(CFLAGS) $(IOSSIM_DEPLOYMENT_ARGS)<br>
> +CFLAGS.profile_ios.x86_64 := $(CFLAGS) $(IOSSIM_DEPLOYMENT_ARGS)<br>
> +CFLAGS.profile_ios.armv7  := $(CFLAGS) $(IOS_DEPLOYMENT_ARGS)<br>
> +CFLAGS.profile_ios.armv7f := $(CFLAGS) $(IOS_DEPLOYMENT_ARGS)<br>
> +CFLAGS.profile_ios.armv7k := $(CFLAGS) $(IOS_DEPLOYMENT_ARGS)<br>
> +CFLAGS.profile_ios.armv7s := $(CFLAGS) $(IOS_DEPLOYMENT_ARGS)<br>
> +<br>
> # Use our stub SDK as the sysroot to support more portable building.<br>
> OSX_DEPLOYMENT_ARGS += -isysroot $(ProjSrcRoot)/SDKs/darwin<br>
> IOS_DEPLOYMENT_ARGS += -isysroot $(ProjSrcRoot)/SDKs/darwin<br>
> @@ -152,14 +164,6 @@ CFLAGS.cc_kext_ios5.armv7  := $(CFLAGS)<br>
> CFLAGS.cc_kext_ios5.armv7f := $(CFLAGS) $(IOS_DEPLOYMENT_ARGS)<br>
> CFLAGS.cc_kext_ios5.armv7k := $(CFLAGS) $(IOS_DEPLOYMENT_ARGS)<br>
> CFLAGS.cc_kext_ios5.armv7s := $(CFLAGS) $(IOS_DEPLOYMENT_ARGS)<br>
> -CFLAGS.profile_osx.i386   := $(CFLAGS) $(OSX_DEPLOYMENT_ARGS)<br>
> -CFLAGS.profile_osx.x86_64 := $(CFLAGS) $(OSX_DEPLOYMENT_ARGS)<br>
> -CFLAGS.profile_ios.i386   := $(CFLAGS) $(IOSSIM_DEPLOYMENT_ARGS)<br>
> -CFLAGS.profile_ios.x86_64 := $(CFLAGS) $(IOSSIM_DEPLOYMENT_ARGS)<br>
> -CFLAGS.profile_ios.armv7  := $(CFLAGS) $(IOS_DEPLOYMENT_ARGS)<br>
> -CFLAGS.profile_ios.armv7f := $(CFLAGS) $(IOS_DEPLOYMENT_ARGS)<br>
> -CFLAGS.profile_ios.armv7k := $(CFLAGS) $(IOS_DEPLOYMENT_ARGS)<br>
> -CFLAGS.profile_ios.armv7s := $(CFLAGS) $(IOS_DEPLOYMENT_ARGS)<br>
><br>
> # Configure the asan_osx_dynamic library to be built shared.<br>
> SHARED_LIBRARY.asan_osx_dynamic := 1<br>
><br>
> Modified: compiler-rt/trunk/make/platform/<a href="http://clang_linux.mk" target="_blank">clang_linux.mk</a><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/make/platform/clang_linux.mk?rev=184805&r1=184804&r2=184805&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/make/platform/clang_linux.mk?rev=184805&r1=184804&r2=184805&view=diff</a><br>

> ==============================================================================<br>
> --- compiler-rt/trunk/make/platform/<a href="http://clang_linux.mk" target="_blank">clang_linux.mk</a> (original)<br>
> +++ compiler-rt/trunk/make/platform/<a href="http://clang_linux.mk" target="_blank">clang_linux.mk</a> Mon Jun 24 19:57:06 2013<br>
> @@ -112,12 +112,10 @@ LDFLAGS.asan-arm-android := $(LDFLAGS) $<br>
>       -Wl,-soname=<a href="http://libclang_rt.asan-arm-android.so" target="_blank">libclang_rt.asan-arm-android.so</a><br>
><br>
> # Use our stub SDK as the sysroot to support more portable building. For now we<br>
> -# just do this for the non-ASAN modules, because the stub SDK doesn't have<br>
> -# enough support to build ASAN.<br>
> +# just do this for the core module, because the stub SDK doesn't have<br>
> +# enough support to build the sanitizers or profile runtimes.<br>
> CFLAGS.full-i386 += --sysroot=$(ProjSrcRoot)/SDKs/linux<br>
> CFLAGS.full-x86_64 += --sysroot=$(ProjSrcRoot)/SDKs/linux<br>
> -CFLAGS.profile-i386 += --sysroot=$(ProjSrcRoot)/SDKs/linux<br>
> -CFLAGS.profile-x86_64 += --sysroot=$(ProjSrcRoot)/SDKs/linux<br>
><br>
> FUNCTIONS.full-i386 := $(CommonFunctions) $(ArchFunctions.i386)<br>
> FUNCTIONS.full-x86_64 := $(CommonFunctions) $(ArchFunctions.x86_64)<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>