<div dir="ltr">Thanks. I will remove them too in another patch.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jun 21, 2013 at 12:35 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I used this grep pattern and found more of it :-<br>
find . -name '*.h' -o -name '*.cpp' | xargs grep '(.*class.*)'<br>
<br>
./lib/ReaderWriter/Native/<u></u>WriterNative.cpp: uint32_t getContentOffset(const class DefinedAtom& atom) {<br>
./lib/ReaderWriter/Native/<u></u>WriterNative.cpp: uint32_t getAttributeOffset(const class DefinedAtom& atom) {<br>
./lib/ReaderWriter/Native/<u></u>WriterNative.cpp: uint32_t getAttributeOffset(const class AbsoluteAtom& atom) {<br>
./lib/ReaderWriter/Native/<u></u>WriterNative.cpp: uint32_t sectionNameOffset(const class DefinedAtom& atom) {<br>
./lib/ReaderWriter/MachO/<u></u>WriterMachO.cpp: DyldInfoChunk(class MachOWriter &);<br>
./lib/ReaderWriter/MachO/<u></u>WriterMachO.cpp: BindingInfoChunk(class MachOWriter &);<br>
./lib/ReaderWriter/MachO/<u></u>WriterMachO.cpp: LazyBindingInfoChunk(class MachOWriter &);<br>
./lib/ReaderWriter/MachO/<u></u>WriterMachO.cpp: SymbolTableChunk(class SymbolStringsChunk&, MachOWriter&);<br>
./lib/Core/Resolver.cpp:void Resolver::doUndefinedAtom(<u></u>const class UndefinedAtom& atom) {<br>
./include/lld/Core/InputFiles.<u></u>h: virtual void doFile(const class File &) = 0;<br>
./include/lld/Core/InputFiles.<u></u>h: virtual void doDefinedAtom(const class DefinedAtom &) = 0;<br>
./include/lld/Core/InputFiles.<u></u>h: virtual void doUndefinedAtom(const class UndefinedAtom &) = 0;<br>
./include/lld/Core/InputFiles.<u></u>h: virtual void doSharedLibraryAtom(const class SharedLibraryAtom &) = 0;<br>
./include/lld/Core/InputFiles.<u></u>h: virtual void doAbsoluteAtom(const class AbsoluteAtom &) = 0;<br>
./include/lld/Core/Resolver.h: virtual void doDefinedAtom(const class DefinedAtom&);<br>
./include/lld/Core/Resolver.h: virtual void doUndefinedAtom(const class UndefinedAtom&);<br>
./include/lld/Core/Resolver.h: virtual void doSharedLibraryAtom(const class SharedLibraryAtom &);<br>
./include/lld/Core/Resolver.h: virtual void doAbsoluteAtom(const class AbsoluteAtom &);<br>
<br>
Thanks<br>
<br>
Shankar Easwaran<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
On 6/21/2013 2:30 PM, Rui Ueyama wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ruiu<br>
Date: Fri Jun 21 14:30:16 2013<br>
New Revision: 184585<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=184585&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=184585&view=rev</a><br>
Log:<br>
Removed unnecessary "class" keyword.<br>
<br>
Modified:<br>
lld/trunk/include/lld/Core/<u></u>Atom.h<br>
lld/trunk/include/lld/Core/<u></u>Reference.h<br>
lld/trunk/include/lld/<u></u>ReaderWriter/Simple.h<br>
lld/trunk/lib/ReaderWriter/<u></u>PECOFF/Atoms.h<br>
<br>
Modified: lld/trunk/include/lld/Core/<u></u>Atom.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/Atom.h?rev=184585&r1=184584&r2=184585&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/include/lld/<u></u>Core/Atom.h?rev=184585&r1=<u></u>184584&r2=184585&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/include/lld/Core/<u></u>Atom.h (original)<br>
+++ lld/trunk/include/lld/Core/<u></u>Atom.h Fri Jun 21 14:30:16 2013<br>
@@ -53,7 +53,7 @@ public:<br>
/// file - returns the File that produced/owns this Atom<br>
- virtual const class File& file() const = 0;<br>
+ virtual const File& file() const = 0;<br>
/// name - The name of the atom. For a function atom, it is the (mangled)<br>
/// name of the function.<br>
<br>
Modified: lld/trunk/include/lld/Core/<u></u>Reference.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/Reference.h?rev=184585&r1=184584&r2=184585&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/include/lld/<u></u>Core/Reference.h?rev=184585&<u></u>r1=184584&r2=184585&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/include/lld/Core/<u></u>Reference.h (original)<br>
+++ lld/trunk/include/lld/Core/<u></u>Reference.h Fri Jun 21 14:30:16 2013<br>
@@ -14,6 +14,7 @@<br>
#include "llvm/ADT/StringSwitch.h"<br>
namespace lld {<br>
+class Atom;<br>
///<br>
/// The linker has a Graph Theory model of linking. An object file is seen<br>
@@ -81,11 +82,11 @@ public:<br>
/// If the reference is an edge to another Atom, then this returns the<br>
/// other Atom. Otherwise, it returns nullptr.<br>
- virtual const class Atom * target() const = 0;<br>
+ virtual const Atom *target() const = 0;<br>
/// During linking, the linker may merge graphs which coalesces some nodes<br>
/// (i.e. Atoms). To switch the target of a reference, this method is called.<br>
- virtual void setTarget(const class Atom *) = 0;<br>
+ virtual void setTarget(const Atom *) = 0;<br>
/// Some relocations require a symbol and a value (e.g. foo + 4).<br>
virtual Addend addend() const = 0;<br>
<br>
Modified: lld/trunk/include/lld/<u></u>ReaderWriter/Simple.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/ReaderWriter/Simple.h?rev=184585&r1=184584&r2=184585&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/include/lld/<u></u>ReaderWriter/Simple.h?rev=<u></u>184585&r1=184584&r2=184585&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/include/lld/<u></u>ReaderWriter/Simple.h (original)<br>
+++ lld/trunk/include/lld/<u></u>ReaderWriter/Simple.h Fri Jun 21 14:30:16 2013<br>
@@ -176,7 +176,7 @@ public:<br>
}<br>
/// file - returns the File that produced/owns this Atom<br>
- virtual const class File &file() const { return _file; }<br>
+ virtual const File &file() const { return _file; }<br>
/// name - The name of the atom. For a function atom, it is the (mangled)<br>
/// name of the function.<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/<u></u>PECOFF/Atoms.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/Atoms.h?rev=184585&r1=184584&r2=184585&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/<u></u>ReaderWriter/PECOFF/Atoms.h?<u></u>rev=184585&r1=184584&r2=<u></u>184585&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/ReaderWriter/<u></u>PECOFF/Atoms.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/<u></u>PECOFF/Atoms.h Fri Jun 21 14:30:16 2013<br>
@@ -60,7 +60,7 @@ public:<br>
COFFAbsoluteAtom(const File &f, llvm::StringRef n, const coff_symbol *s)<br>
: _owningFile(f), _name(n), _symbol(s) {}<br>
- virtual const class File &file() const { return _owningFile; }<br>
+ virtual const File &file() const { return _owningFile; }<br>
virtual Scope scope() const {<br>
if (_symbol->StorageClass == llvm::COFF::IMAGE_SYM_CLASS_<u></u>STATIC)<br>
@@ -83,7 +83,7 @@ public:<br>
COFFUndefinedAtom(const File &f, llvm::StringRef n)<br>
: _owningFile(f), _name(n) {}<br>
- virtual const class File &file() const { return _owningFile; }<br>
+ virtual const File &file() const { return _owningFile; }<br>
virtual llvm::StringRef name() const { return _name; }<br>
@@ -102,7 +102,7 @@ public:<br>
: _owningFile(f), _name(n), _symbol(symb), _section(sec), _data(d),<br>
_sectionName(sectionName), _ordinal(ordinal) {}<br>
- virtual const class File &file() const { return _owningFile; }<br>
+ virtual const File &file() const { return _owningFile; }<br>
virtual llvm::StringRef name() const { return _name; }<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
<br>
</blockquote>
<br>
<br></div></div><span class="HOEnZb"><font color="#888888">
-- <br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation<br>
<br>
</font></span></blockquote></div><br></div>