<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Pekka, </div><div><br></div><div>LGTM. Please also make sure that we are not dropping the address space for Loads. </div><div><br></div><div>Thanks,</div><div>Nadav</div><br><div><div>On Jun 17, 2013, at 10:57 AM, Eli Friedman <<a href="mailto:eli.friedman@gmail.com">eli.friedman@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr">Forwarding to the correct list.<br><br><div class="gmail_quote">---------- Forwarded message ----------<br>From:<span class="Apple-converted-space"> </span><b class="gmail_sendername">Pekka Jääskeläinen</b><span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:pekka.jaaskelainen@tut.fi">pekka.jaaskelainen@tut.fi</a>></span><br>Date: Mon, Jun 17, 2013 at 8:06 AM<br>Subject: [patch] fix loopvectorizer bug with multiple address spaces PR16306<br>To:<span class="Apple-converted-space"> </span><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><br><br>Hello,<br><br>Attached patch fixes a severe regression caused by LoopVectorizer when<br>vectorizing loops with memory accesses to non-zero address spaces. It<br>simply drops the AS info. It's a rather nasty problem as there is no<br>way (at least known to me) to disable the loop vectorizer *only* from<br>clang/opt command line.<br><br>Seems like an obvious fix.<br><br><a href="http://llvm.org/bugs/show_bug.cgi?id=16306" target="_blank">http://llvm.org/bugs/show_bug.<u></u>cgi?id=16306</a><br><br>The patch applies to trunk and 3.3 branches. Tom, could you apply<br>this to the (upcoming?) 3.3 maintenance branch as well?<br><br>Thanks,<span class="HOEnZb"><font color="#888888"><br>--<span class="Apple-converted-space"> </span><br>--Pekka<br></font></span><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br><br></div><br></div><span><loopvec-address-space-fix.patch></span></div></blockquote></div><br></body></html>