<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>I can see that you fixed both places. Excellent. You can ignore my second email. </div><br><div><div>On Jun 17, 2013, at 11:49 AM, Pekka Jaaskelainen <<a href="mailto:pekka.jaaskelainen@tut.fi">pekka.jaaskelainen@tut.fi</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Author: pjaaskel<br>Date: Mon Jun 17 13:49:06 2013<br>New Revision: 184103<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=184103&view=rev">http://llvm.org/viewvc/llvm-project?rev=184103&view=rev</a><br>Log:<br>Fix for a regression caused by the LoopVectorizer when<br>vectorizing loops with memory accesses to non-zero address spaces. It<br>simply dropped the AS info. Fixes PR16306.<br><br><br>Added:<br> llvm/trunk/test/Transforms/LoopVectorize/multiple-address-spaces.ll<br>Modified:<br> llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp<br><br>Modified: llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp?rev=184103&r1=184102&r2=184103&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp?rev=184103&r1=184102&r2=184103&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp (original)<br>+++ llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp Mon Jun 17 13:49:06 2013<br>@@ -1178,7 +1178,7 @@ void InnerLoopVectorizer::vectorizeMemor<br> Type *DataTy = VectorType::get(ScalarDataTy, VF);<br> Value *Ptr = LI ? LI->getPointerOperand() : SI->getPointerOperand();<br> unsigned Alignment = LI ? LI->getAlignment() : SI->getAlignment();<br>-<br>+ unsigned AddressSpace = Ptr->getType()->getPointerAddressSpace();<br> unsigned ScalarAllocatedSize = DL->getTypeAllocSize(ScalarDataTy);<br> unsigned VectorElementSize = DL->getTypeStoreSize(DataTy)/VF;<br><br>@@ -1253,7 +1253,7 @@ void InnerLoopVectorizer::vectorizeMemor<br> PartPtr = Builder.CreateGEP(PartPtr, Builder.getInt32(1 - VF));<br> }<br><br>- Value *VecPtr = Builder.CreateBitCast(PartPtr, DataTy->getPointerTo());<br>+ Value *VecPtr = Builder.CreateBitCast(PartPtr, DataTy->getPointerTo(AddressSpace));<br> Builder.CreateStore(StoredVal[Part], VecPtr)->setAlignment(Alignment);<br> }<br> }<br>@@ -1269,7 +1269,7 @@ void InnerLoopVectorizer::vectorizeMemor<br> PartPtr = Builder.CreateGEP(PartPtr, Builder.getInt32(1 - VF));<br> }<br><br>- Value *VecPtr = Builder.CreateBitCast(PartPtr, DataTy->getPointerTo());<br>+ Value *VecPtr = Builder.CreateBitCast(PartPtr, DataTy->getPointerTo(AddressSpace));<br> Value *LI = Builder.CreateLoad(VecPtr, "wide.load");<br> cast<LoadInst>(LI)->setAlignment(Alignment);<br> Entry[Part] = Reverse ? reverseVector(LI) : LI;<br><br>Added: llvm/trunk/test/Transforms/LoopVectorize/multiple-address-spaces.ll<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/LoopVectorize/multiple-address-spaces.ll?rev=184103&view=auto">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/LoopVectorize/multiple-address-spaces.ll?rev=184103&view=auto</a><br>==============================================================================<br>--- llvm/trunk/test/Transforms/LoopVectorize/multiple-address-spaces.ll (added)<br>+++ llvm/trunk/test/Transforms/LoopVectorize/multiple-address-spaces.ll Mon Jun 17 13:49:06 2013<br>@@ -0,0 +1,47 @@<br>+; RUN: opt < %s -loop-vectorize -force-vector-unroll=1 -force-vector-width=4 -dce -instcombine -S | FileCheck %s<br>+<br>+; From a simple program with two address spaces:<br>+; char Y[4*10000] __attribute__((address_space(1)));<br>+; char X[4*10000];<br>+; int main() {<br>+; for (int i = 0; i < 4*10000; ++i)<br>+; X[i] = Y[i] + 1;<br>+; return 0;<br>+;}<br>+<br>+<br>+target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"<br>+target triple = "x86_64-unknown-linux-gnu"<br>+<br>+@Y = common addrspace(1) global [40000 x i8] zeroinitializer, align 16<br>+@X = common global [40000 x i8] zeroinitializer, align 16<br>+<br>+;CHECK: @main<br>+;CHECK: bitcast i8 addrspace(1)* %{{.*}} to <4 x i8> addrspace(1)*<br>+;CHECK: bitcast i8* %{{.*}} to <4 x i8>*<br>+<br>+; Function Attrs: nounwind uwtable<br>+define i32 @main() #0 {<br>+entry:<br>+ br label %for.body<br>+<br>+for.body: ; preds = %for.body, %entry<br>+ %indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ]<br>+ %arrayidx = getelementptr inbounds [40000 x i8] addrspace(1)* @Y, i64 0, i64 %indvars.iv<br>+ %0 = load i8 addrspace(1)* %arrayidx, align 1, !tbaa !0<br>+ %add = add i8 %0, 1<br>+ %arrayidx3 = getelementptr inbounds [40000 x i8]* @X, i64 0, i64 %indvars.iv<br>+ store i8 %add, i8* %arrayidx3, align 1, !tbaa !0<br>+ %indvars.iv.next = add i64 %indvars.iv, 1<br>+ %lftr.wideiv = trunc i64 %indvars.iv.next to i32<br>+ %exitcond = icmp eq i32 %lftr.wideiv, 40000<br>+ br i1 %exitcond, label %for.end, label %for.body<br>+<br>+for.end: ; preds = %for.body<br>+ ret i32 0<br>+}<br>+<br>+attributes #0 = { nounwind uwtable "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-frame-pointer-elim-non-leaf"="false" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "unsafe-fp-math"="false" "use-soft-float"="false" }<br>+<br>+!0 = metadata !{metadata !"omnipotent char", metadata !1}<br>+!1 = metadata !{metadata !"Simple C/C++ TBAA"}<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></body></html>