<div dir="ltr">WDYT of replacing cpplint with ClangFormat? Or at least adding a command to automatically reformat all the sanitizers code with ClangFormat?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 11, 2013 at 12:37 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">That would be lovely indeed. </div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br>
<div class="gmail_quote">On Tue, Jun 11, 2013 at 12:41 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Mon, Jun 10, 2013 at 3:00 AM, Dmitry Vyukov <<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>> wrote:<br>


> Author: dvyukov<br>
> Date: Mon Jun 10 05:00:54 2013<br>
> New Revision: 183642<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=183642&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=183642&view=rev</a><br>
> Log:<br>
> tsan: fix lint warnings<br>
<br>
</div>This seems to be a recurring cleanup task - is there a reason it's not<br>
part of the default/commonly-used build targets for compiler-rt?<br>
<div><div><br>
><br>
> Modified:<br>
>     compiler-rt/trunk/lib/lsan/lit_tests/TestCases/ignore_object.cc<br>
>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc<br>
>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.h<br>
><br>
> Modified: compiler-rt/trunk/lib/lsan/lit_tests/TestCases/ignore_object.cc<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/lsan/lit_tests/TestCases/ignore_object.cc?rev=183642&r1=183641&r2=183642&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/lsan/lit_tests/TestCases/ignore_object.cc?rev=183642&r1=183641&r2=183642&view=diff</a><br>


> ==============================================================================<br>
> --- compiler-rt/trunk/lib/lsan/lit_tests/TestCases/ignore_object.cc (original)<br>
> +++ compiler-rt/trunk/lib/lsan/lit_tests/TestCases/ignore_object.cc Mon Jun 10 05:00:54 2013<br>
> @@ -26,5 +26,5 @@ int main() {<br>
>    return 0;<br>
>  }<br>
>  // CHECK: Test alloc: [[ADDR:.*]].<br>
> -// CHECK: ignoring heap object at [[ADDR]]<br>
> +// CHECK: ignoring heap object at [[ADDR]]<br>
>  // CHECK: SUMMARY: LeakSanitizer: 1337 byte(s) leaked in 1 allocation(s)<br>
><br>
> Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc?rev=183642&r1=183641&r2=183642&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc?rev=183642&r1=183641&r2=183642&view=diff</a><br>


> ==============================================================================<br>
> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc (original)<br>
> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc Mon Jun 10 05:00:54 2013<br>
> @@ -207,14 +207,15 @@ namespace __sanitizer {<br>
>    unsigned struct_ppp_stats_sz = sizeof(struct ppp_stats);<br>
>    unsigned struct_scc_modem_sz = sizeof(struct scc_modem);<br>
>    unsigned struct_scc_stat_sz = sizeof(struct scc_stat);<br>
> -  unsigned struct_serial_multiport_struct_sz = sizeof(struct serial_multiport_struct);<br>
> +  unsigned struct_serial_multiport_struct_sz<br>
> +      = sizeof(struct serial_multiport_struct);<br>
>    unsigned struct_serial_struct_sz = sizeof(struct serial_struct);<br>
>    unsigned struct_sockaddr_ax25_sz = sizeof(struct sockaddr_ax25);<br>
>    unsigned struct_unimapdesc_sz = sizeof(struct unimapdesc);<br>
>    unsigned struct_unimapinit_sz = sizeof(struct unimapinit);<br>
>  #endif<br>
><br>
> -#if !SANITIZER_ANDROID<br>
> +#if !SANITIZER_ANDROID<br>
>    unsigned struct_sioc_sg_req_sz = sizeof(struct sioc_sg_req);<br>
>    unsigned struct_sioc_vif_req_sz = sizeof(struct sioc_vif_req);<br>
>  #endif<br>
><br>
> Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.h?rev=183642&r1=183641&r2=183642&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.h?rev=183642&r1=183641&r2=183642&view=diff</a><br>


> ==============================================================================<br>
> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.h (original)<br>
> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.h Mon Jun 10 05:00:54 2013<br>
> @@ -219,7 +219,7 @@ namespace __sanitizer {<br>
>    extern unsigned struct_unimapdesc_sz;<br>
>    extern unsigned struct_unimapinit_sz;<br>
>  #endif<br>
> -<br>
> +<br>
>  #if !SANITIZER_ANDROID<br>
>    extern unsigned struct_sioc_sg_req_sz;<br>
>    extern unsigned struct_sioc_vif_req_sz;<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div>