<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Hi JF,</div><div>Below are a few comments.</div><div><br></div><div>The for loop should be written as:</div><div><br></div><div><div>for (unsigned i = 0, e = sizeof(FoldableExtends) / sizeof(FoldableExtends[0]); i < e; ++i) {</div></div><div> . . .</div><div>}</div><div><br></div><div>Are there existing test cases that exercise this code? If not, please add the necessary test cases.</div><div><br></div><div>Otherwise, LGTM.</div><div><br></div><div> Chad</div><div><br></div><br><div><div>On Jun 8, 2013, at 12:46 PM, JF Bastien <<a href="mailto:jfb@google.com">jfb@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">This was the wrong patch, here's the correct one.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Jun 8, 2013 at 12:26 PM, JF Bastien <span dir="ltr"><<a href="mailto:jfb@google.com" target="_blank">jfb@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sign- and zero-extension folding was slightly incorrect because it wasn't checking that the shift on extensions was zero. Further, I recently added AND rd, rn, #255 as a form of 8-bit zero extension, and failed to add the folding code for it.<div>
<br></div><div>This patch fixes both issues.<br><div><br></div><div>This patch fixes both, and the test should remain the same:</div><div> test/CodeGen/ARM/fast-isel-fold.ll<br></div><div><br></div></div>
</div>
</blockquote></div><br></div>
<span><fastisel-fix-ext-fold.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></body></html>