<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Chandler, hi Sean,<div><br></div><div>I will move forward and commit the proposed patch.</div><div><br></div><div>I have assigned the bug related to supporting -Wframe-larger-than <<a href="http://llvm.org/bugs/show_bug.cgi?id=4072">http://llvm.org/bugs/show_bug.cgi?id=4072</a>> to myself.</div><div><br></div><div>I plan to work on that in the near future.</div><div><br></div><div>Thanks again for the insightful comments.</div><div><br><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div><div>On Jun 6, 2013, at 4:23 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Hi Chandler,</div><div><br></div><div>Thanks for the quick answer (unlike me!).</div><div><br></div><div>I do not know yet if I will have time to make the implementation to finish this.</div><div>Therefore, at the moment, I will not commit the proposed patch and I will not sign up for doing the equivalent of -Wframe-larger-than.</div><div><br></div><div>This may change in the next weeks or so :).</div><div><br></div><div>-Quentin</div><div><br></div><div><br></div><div><div>On Jun 5, 2013, at 5:13 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr">On Wed, Jun 5, 2013 at 4:51 PM, Quentin Colombet<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:qcolombet@apple.com" target="_blank" class="cremed">qcolombet@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;">Hi Chandler, hi Sean,<div><br></div><div>I wanted to double check with you what is your opinion about the proposed patch.</div><div><br></div><div>Sean, it seems you agree that this gets in, but additionally we need to make a plan for the future.</div><div><br></div><div>Chandler, you did not want it in until it gets a warning in clang. How Evan’s comment affected your thought?</div><div><br></div><div>If you both agree, I can commit this patch and start a discussion on llvm-dev regarding how we can support backend warnings into clang.</div><div><br></div><div>What do you think?</div></div></blockquote><div><br></div><div>I'm fine with whatever incremental approach towards getting a warning into clang you want to pursue, I just don't want it to muck up the code too much to get there, and I don't want it to languish for the next 6 months without getting there. ;] I'm not sure how much the patch you have helps get us to the right end state (and I do mean I'm not sure, I haven't really thought about it), I just want to make sure that the patches going in are trying to move us toward a clean and maintainable end state.</div><div><br></div><div>If you're signing up to get something in place to finish this and implement (the equivalent of) -Wframe-larger-than=, I don't want to get in the way of whatever seems like a reasonable implementation path to you. =]</div></div></div></div></div></blockquote></div><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></body></html>