<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 5, 2013 at 12:07 AM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Tue, Jun 4, 2013 at 7:06 AM, Evgeniy Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br>
</div></div><div class="gmail_quote"><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: eugenis<br>
Date: Tue Jun  4 09:06:16 2013<br>
New Revision: 183225<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=183225&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=183225&view=rev</a><br>
Log:<br>
[sanitizer] Fix windows build.<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_internal_defs.h<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_internal_defs.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_internal_defs.h?rev=183225&r1=183224&r2=183225&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_internal_defs.h?rev=183225&r1=183224&r2=183225&view=diff</a><br>


==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_internal_defs.h (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_internal_defs.h Tue Jun  4 09:06:16 2013<br>
@@ -68,14 +68,6 @@ typedef signed   int s32;<br>
 typedef signed   long long s64;  // NOLINT<br>
 typedef int fd_t;<br>
<br>
-// Unaligned versions.<br>
-typedef __attribute__((aligned(1))) u16 uu16;<br>
-typedef __attribute__((aligned(1))) u32 uu32;<br>
-typedef __attribute__((aligned(1))) u64 uu64;<br>
-typedef __attribute__((aligned(1))) s16 us16;<br>
-typedef __attribute__((aligned(1))) s32 us32;<br>
-typedef __attribute__((aligned(1))) s64 us64;<br>
-<br>
 // WARNING: OFF_T may be different from OS type off_t, depending on the value of<br>
 // _FILE_OFFSET_BITS. This definition of OFF_T matches the ABI of system calls<br>
 // like pread and mmap, as opposed to pread64 and mmap64.<br>
@@ -160,6 +152,14 @@ using namespace __sanitizer;  // NOLINT<br>
 # endif<br>
 #endif  // _MSC_VER<br>
<br>
+// Unaligned versions of basic types.<br>
+typedef ALIGNED(1) u16 uu16;<br>
+typedef ALIGNED(1) u32 uu32;<br>
+typedef ALIGNED(1) u64 uu64;<br>
+typedef ALIGNED(1) s16 us16;<br>
+typedef ALIGNED(1) s32 us32;<br>
+typedef ALIGNED(1) s64 us64;</blockquote><div><br></div></div></div><div>We have a fair amount of experience showing that usage of alignment attributes is very subtle and prone to portability issues. Can you use memcpy instead?</div>
</div></blockquote><div><br></div><div style>This part is actually performance critical. </div><div style>We had at least one piece of code where we initially used memcpy, but had to revert to __sanitizer_unaligned_load (which uses a simple load) to recover part of performance. </div>
<div><br></div><div><br></div><div style>--kcc</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote">
</div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>