<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 06/05/2013 12:55 PM, Owen Anderson
wrote:<br>
</div>
<blockquote cite="mid:96E3067E-A4B6-4474-A4DF-518CA2CECFF6@mac.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
Hey,
<div><br>
</div>
<div>I have a serious question about this patch that I raised in a
prior email, and I'd appreciate it if you'd address it rather
than continuing in the opposite direction.</div>
<div><br>
<div>
<div>On Jun 5, 2013, at 12:42 PM, Matt Arsenault <<a
moz-do-not-send="true"
href="mailto:Matthew.Arsenault@amd.com">Matthew.Arsenault@amd.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite"> Move NearestCommonDominator to
separate file<br>
<br>
<a moz-do-not-send="true"
href="http://llvm-reviews.chandlerc.com/D906">http://llvm-reviews.chandlerc.com/D906</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
<a class="moz-txt-link-freetext" href="http://llvm-reviews.chandlerc.com/D906?vs=2252&id=2279#toc">http://llvm-reviews.chandlerc.com/D906?vs=2252&id=2279#toc</a><br>
<br>
Files:<br>
include/llvm/Analysis/NearestCommonDominator.h<br>
</blockquote>
<div><br>
</div>
<div>I don't understand why this analysis is necessary. We
already have pair-wise nearestCommonDominator functionality
built into DomTree. If it needs to be extended to support
multi-block NCD queries, that should be possible to
implement on top of the existing functionality rather than
build a new analysis on top of it.</div>
<br>
</div>
</div>
</blockquote>
I was wondering about that after you asked, but I thought that
Christian had addressed it earlier today.<br>
<br>
<blockquote cite="mid:96E3067E-A4B6-4474-A4DF-518CA2CECFF6@mac.com"
type="cite">
<div>More generally, I don't understand why it's desirable to
move this out of the R600 target. The comments hand wave about
it being useful for other targets, but I don't see anyone
actually planning to use it. If there is interest in it from
other targets, then you probably need to <i>start</i> by having
a conversation with other target authors about what kind of
common canonical form different targets can share rather than
simply foisting whatever was convenient for R600 onto them.</div>
<div><br>
</div>
<div>--Owen</div>
</blockquote>
<br>
I'm interested in using it in the AMDIL target, which is why I want
to do this.<br>
</body>
</html>