<div dir="ltr">Presumably for the same reason why we use ldr for 'ptrtoint (i32* @a to i32)' instead of movw/movt. Why do you ask? Do you think using ldrb is incorrect?<div><br></div><div>-- </div><div style>David Majnemer</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 4, 2013 at 5:43 PM, JF Bastien <span dir="ltr"><<a href="mailto:jfb@google.com" target="_blank">jfb@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">I'm not sure I understand: why is it that ldrb ever gets emitted instead of movs with immediate?</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 4, 2013 at 10:46 AM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: majnemer<br>
Date: Tue Jun  4 12:46:15 2013<br>
New Revision: 183238<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=183238&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=183238&view=rev</a><br>
Log:<br>
ARM: Fix crash in ARM backend inside of ARMConstantIslandPass<br>
<br>
The ARM backend did not expect LDRBi12 to hold a constant pool operand.<br>
Allow for LLVM to deal with the instruction similar to how it deals with<br>
LDRi12.<br>
<br>
This fixes PR16215.<br>
<br>
Added:<br>
    llvm/trunk/test/CodeGen/ARM/load-address-masked.ll<br>
Modified:<br>
    llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp?rev=183238&r1=183237&r2=183238&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp?rev=183238&r1=183237&r2=183238&view=diff</a><br>


==============================================================================<br>
--- llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp (original)<br>
+++ llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp Tue Jun  4 12:46:15 2013<br>
@@ -753,6 +753,7 @@ initializeFunctionInfo(const std::vector<br>
             Scale = 4;<br>
             break;<br>
<br>
+          case ARM::LDRBi12:<br>
           case ARM::LDRi12:<br>
           case ARM::LDRcp:<br>
           case ARM::t2LDRpci:<br>
<br>
Added: llvm/trunk/test/CodeGen/ARM/load-address-masked.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/load-address-masked.ll?rev=183238&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/load-address-masked.ll?rev=183238&view=auto</a><br>


==============================================================================<br>
--- llvm/trunk/test/CodeGen/ARM/load-address-masked.ll (added)<br>
+++ llvm/trunk/test/CodeGen/ARM/load-address-masked.ll Tue Jun  4 12:46:15 2013<br>
@@ -0,0 +1,14 @@<br>
+; RUN: llc < %s -mtriple=armv4t-unknown-linux-gnueabi -verify-machineinstrs | FileCheck %s<br>
+<br>
+target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:64:128-a0:0:64-n32-S64"<br>
+target triple = "armv4t-unknown-linux-gnueabi"<br>
+<br>
+@a = global i32 0, align 4<br>
+<br>
+define i32 @foo() {<br>
+entry:<br>
+  ret i32 and (i32 ptrtoint (i32* @a to i32), i32 255)<br>
+}<br>
+<br>
+; CHECK: foo:<br>
+; CHECK: ldrb    r0, .LCPI0_0<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>