<div dir="ltr"><div><div>Done.<br>r182955 and r182956.<br><br></div>These changes require master restart. I'll do this at the end of the day tomorrow.<br></div>Please make sure your slave is up and running by then.<br>
<div><div><br>Thanks<br> <br>Galina<br></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, May 30, 2013 at 10:49 AM, Gabor Ballabas <span dir="ltr"><<a href="mailto:gaborb@inf.u-szeged.hu" target="_blank">gaborb@inf.u-szeged.hu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    Hello Galina,<br>
    <br>
    I am not familiar with the commit process so I would appreciate it
    if you could do that for me.<div class="im"><br>
    Thanks for the review.<br>
    <br>
    Best regards,<br>
    Gabor Ballabas<br>
    <br>
    <br></div><div><div class="h5">
    On 05/30/13 19:27, Galina Kistanova wrote:
    <blockquote type="cite">
      <div dir="ltr">
        <div>Looks good now.</div>
        <div>Please feel free to commit or let me know if you want me
          commit it for you.</div>
        <div> </div>
        <div>Thanks for working on this!</div>
        <div> </div>
        <div>Thanks</div>
        <div> </div>
        <div>
          Galina</div>
        <div class="gmail_extra"><br>
          <br>
          <div class="gmail_quote">On Wed, May 29, 2013 at 9:08 AM,
            Gabor Ballabas <span dir="ltr"><<a href="mailto:gaborb@inf.u-szeged.hu" target="_blank">gaborb@inf.u-szeged.hu</a>></span>
            wrote:<br>
            <blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote">Hello Galina,<br>
              <div><br>
                On 05/29/13 06:49, Galina Kistanova wrote:<br>
                > Hello Gabor,<br>
                ><br>
                > The patch looks Ok.<br>
                ><br>
                > There are two small things:<br>
                ><br>
                > > -    configure_args = ["./configure"]<br>
                > > +    configure_args =
                [WithProperties("%(builddir)s/" +<br>
                > "llvm/configure")]<br>
                > > +    # configure_args = [WithProperties("%s/"
                + "llvm/configure",<br>
                > "builddir")]<br>
                ><br>
                > Why do you need the commented line?<br>
                ><br>
                <br>
              </div>
              Oops! Obviously that line is not needed at all. I've
              removed it.<br>
              <div><br>
                > And for consistency with other builders, could you
                define llvm_srcdir<br>
                > (set it to "llvm" for in-tree or "llvm.src" for
                out-of-tree builds),<br>
                > and use it instead of hardcoded "llvm", please?<br>
                <br>
              </div>
              Done.<br>
              <br>
              I attached the final versions of both patches.<br>
              Thanks for your help.<br>
              <br>
              Best regards,<br>
              Gabor Ballabas<br>
              <br>
              <br>
            </blockquote>
          </div>
          <br>
        </div>
      </div>
    </blockquote>
    <br>
  </div></div></div>

</blockquote></div><br></div>