<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 29, 2013 at 12:32 AM, Patrik Hagglund <span dir="ltr"><<a href="mailto:patrik.h.hagglund@ericsson.com" target="_blank">patrik.h.hagglund@ericsson.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: patha<br>
Date: Wed May 29 02:32:08 2013<br>
New Revision: 182832<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=182832&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=182832&view=rev</a><br>
Log:<br>
Temporary fix to get rid of gcc warning.<br></blockquote><div><br></div><div style>Generally we prefer to simply disable or fix bad warnings rather than workaround them in code. (which usually amounts to disabling GCC warnings and fixing Clang warnings)<br>
<br>Which warning was the problem here & can we just disable it? Does Clang have an equivalent (& better/correct/not-false-positive-on-this-code) warning?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
Modified:<br>
    llvm/trunk/lib/Target/R600/AMDGPUSubtarget.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/R600/AMDGPUSubtarget.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/AMDGPUSubtarget.cpp?rev=182832&r1=182831&r2=182832&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/AMDGPUSubtarget.cpp?rev=182832&r1=182831&r2=182832&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Target/R600/AMDGPUSubtarget.cpp (original)<br>
+++ llvm/trunk/lib/Target/R600/AMDGPUSubtarget.cpp Wed May 29 02:32:08 2013<br>
@@ -37,7 +37,16 @@ AMDGPUSubtarget::AMDGPUSubtarget(StringR<br>
   ParseSubtargetFeatures(GPU, FS);<br>
   DevName = GPU;<br>
   Device = AMDGPUDeviceInfo::getDeviceFromName(DevName, this, Is64bit);<br>
-  TexVTXClauseSize = (Device->getGeneration() >= AMDGPUDeviceInfo::HD4XXX)?16:8;<br>
+<br>
+  // FIXME: The code in the comment below was the original code. But the<br>
+  // condition is always true, generating a warning when compiled with<br>
+  // gcc. Vincent Lejeune indicated in a mail to llvm-commits 2013-05-23 that he<br>
+  // will look into this. The code 'TexVTXClauseSize = 16' is just a temporary<br>
+  // equivalent replacement, to get rid of the compiler warning.<br>
+<br>
+  // TexVTXClauseSize = (Device->getGeneration() >= AMDGPUDeviceInfo::HD4XXX)?16:8;<br>
+<br>
+  TexVTXClauseSize = 16;<br>
 }<br>
<br>
 AMDGPUSubtarget::~AMDGPUSubtarget() {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>