<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Thanks for working on this, JF. I started this a few months ago, but got distracted. It should make debugging with the machine code verifier much easier!<div><br></div><div> Chad<br><div><br><div><div>On May 28, 2013, at 11:36 AM, JF Bastien <<a href="mailto:jfb@google.com">jfb@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div><font face="arial, sans-serif">Add </font><span style="font-family:arial,sans-serif;font-size:13px">-verify-machineinstrs to the Thumb tests that don't have it in </span><span style="font-family:arial,sans-serif">test/CodeGen/ARM/fast-isel*.</span></div>
<div><br></div></div><div class="gmail_extra"><div class="gmail_quote">
On Tue, May 28, 2013 at 11:30 AM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
LGTM. Testcase for where this showed up?<br>
<br>
-eric<br>
<div><div class="h5"><br>
On Tue, May 28, 2013 at 10:43 AM, JF Bastien <<a href="mailto:jfb@google.com">jfb@google.com</a>> wrote:<br>
> Tidy up three places where the register class for ARM and Thumb wasn't<br>
> restrictive enough:<br>
> - No PC dest for reg-reg add/orr/sub.<br>
> - No PC dest for shifts.<br>
> - No PC or SP for Thumb2 reg-imm add.<br>
><br>
> I encountered this while combining FastISel with -verify-machineinstrs.<br>
> These instructions defined registers whose classes weren't restrictive<br>
> enough, and the uses failed verification. They're also undefined in the ISA,<br>
> or would produce code that FastISel wouldn't want. This doesn't fix the<br>
> register class narrowing issue (where uses should restrict definitions), and<br>
> isn't thorough, but it's a small step in the right direction.<br>
><br>
</div></div>> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
</blockquote></div><br></div>
_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></div></body></html>