<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Sat, May 25, 2013 at 1:07 AM, Greg Fitzgerald <span dir="ltr"><<a href="mailto:garious@gmail.com" target="_blank">garious@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks for the review. <div class="im"><div><br></div><div><br></div><div><span style="font-family:arial,sans-serif;font-size:13px">> You would need get_required_attr() here (as in other .cfg files)</span><br>
</div><div>
<span style="font-family:arial,sans-serif;font-size:13px"><br></span></div></div><div><font face="arial, sans-serif">Done. See updated patch attached.</font></div><div class="im"><div><br></div><div><br></div><div><span style="font-family:arial,sans-serif;font-size:13px">> Please submit this if it works for your configuration</span><br>
</div><div><br></div></div><div>Can you either submit this on my behalf or give me commit access to compiler-rt?</div></div></blockquote><div><br></div><div style>Landed in r182726.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div><div><br></div><div>Thanks,</div><div>Greg</div></div></div><div class="gmail_extra">
<br>
<br><div class="gmail_quote"><div><div class="h5">On Fri, May 24, 2013 at 8:21 AM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br></div>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
<div dir="ltr"><div>LGTM (modulo one comment below). Please submit this if it works for your configuration where compiler-rt is checked out in different place.</div><div>Thanks!</div><div><br></div><div>-compiler_rt_lit_cfg = os.path.join(llvm_src_root, "projects", "compiler-rt",</div>
<div>- "lib", "lit.common.cfg")</div><div>+compiler_rt_src_root = getattr(config, 'compiler_rt_src_root', None)</div><div>+compiler_rt_lit_cfg = os.path.join(compiler_rt_src_root, "lib",</div>
<div>+ "lit.common.cfg")</div><div>You would need get_required_attr() here (as in other .cfg files) or check that attr value is not None<br></div><div><br></div><div>
<br></div></div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Fri, May 24, 2013 at 3:42 AM, Greg Fitzgerald <span dir="ltr"><<a href="mailto:gregf@codeaurora.org" target="_blank">gregf@codeaurora.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal">Attached is a patch to fix the compiler-rt build when it is in a directory outside “llvm/projects”. Can you please review?<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">Thanks,<u></u><u></u></p><p class="MsoNormal">Greg<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#222222;background:white">Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted</span><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#222222"><br>
<span style="background:white">by The Linux Foundation</span></span><u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p></div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br>
<div>Alexey Samsonov, MSK</div>
</font></span></div>
<br></div></div>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div></div>