<div dir="ltr">No execution path to get to this code yet. Will be tested in <a href="http://llvm-reviews.chandlerc.com/D865">http://llvm-reviews.chandlerc.com/D865</a>.</div><div class="gmail_extra"><br><br><div class="gmail_quote">

On Mon, May 27, 2013 at 6:35 AM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

testcase?<br>
<div class="HOEnZb"><div class="h5"><br>
On 26 May 2013 19:09, Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:<br>
> Author: ruiu<br>
> Date: Sun May 26 18:09:01 2013<br>
> New Revision: 182721<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=182721&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=182721&view=rev</a><br>
> Log:<br>
> [PECOFF] Skip section names in the symbol table because they are not atoms.<br>
><br>
> Modified:<br>
>     lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp<br>
><br>
> Modified: lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=182721&r1=182720&r2=182721&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=182721&r1=182720&r2=182721&view=diff</a><br>


> ==============================================================================<br>
> --- lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp (original)<br>
> +++ lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp Sun May 26 18:09:01 2013<br>
> @@ -255,6 +255,11 @@ public:<br>
>          UndefinedAtoms._atoms.push_back(<br>
>            new (AtomStorage.Allocate<COFFUndefinedAtom>())<br>
>              COFFUndefinedAtom(*this, Name));<br>
> +      } else if (   Symb->StorageClass == llvm::COFF::IMAGE_SYM_CLASS_STATIC<br>
> +                 && Symb->Value == 0) {<br>
> +        // A symbol with IMAGE_SYM_CLASS_STATIC and zero value represents a<br>
> +        // section name. This is redundant and we can safely skip this here<br>
> +        // because the same section name is also in the section header.<br>
>        } else {<br>
>          // This is actually a defined symbol. Add it to its section's list of<br>
>          // symbols.<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>