<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, May 23, 2013 at 4:54 PM, Timur Iskhodzhanov <span dir="ltr"><<a href="mailto:timurrrr@google.com" target="_blank">timurrrr@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">2013/5/21 Peter Collingbourne <<a href="mailto:peter@pcc.me.uk">peter@pcc.me.uk</a>>:<br>
<div class="im">> Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc?rev=182372&r1=182371&r2=182372&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc?rev=182372&r1=182371&r2=182372&view=diff</a><br>

> ==============================================================================<br>
> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc (original)<br>
> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc Tue May 21 07:08:37 2013<br>
> @@ -85,7 +85,7 @@ void StackTrace::PrintStack(const uptr *<br>
>          frame_num++;<br>
>        }<br>
>      }<br>
> -    if (symbolize && addr_frames_num == 0) {<br>
> +    if (symbolize && addr_frames_num == 0 && SymbolizeCode) {<br>
>        // Use our own (online) symbolizer, if necessary.<br>
>        addr_frames_num = SymbolizeCode(pc, addr_frames.data(),<br>
>                                        addr_frames.size());<br>
<br>
</div>Peter,<br>
<br>
Can you please clarify why you've changed this condition?<br>
This gives a compiler warning when building on Windows (Visual Studio)<br>
as SymbolizeCode is a function name (not function pointer), I believe.<br></blockquote><div><br></div><div style>Peter made it weak pointer, but on Windows we don't have such thing. </div><div style> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
--<br>
Timur<br>
<div class="HOEnZb"><div class="h5">_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>