<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Wed, May 22, 2013 at 12:36 AM, Daniel Dunbar <span dir="ltr"><<a href="mailto:daniel@zuster.org" target="_blank">daniel@zuster.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'm assuming Clang should be able to compile this file everywhere now (seems to work fine for me in all the cases I tried), I am going to reenable it in the build. Please let me know if you see a problem.</div>
</blockquote><div><br></div><div style>OK. I've added this file to CMake build as well in r182453.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><span class="HOEnZb"><font color="#888888"><div>
<br></div><div> - Daniel</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 21, 2013 at 1:12 AM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Daniel!<div><br>This was a fix after <span style="font-family:arial,sans-serif;font-size:13px">LLVM r154579 broke down compiler-rt build on our bot, </span><span style="font-family:arial,sans-serif;font-size:13px">clang failed to compile atomic.c after that revision.</span></div>
<div><font face="arial, sans-serif">If this is fixed now, I'm ok with adding this file back to compiler-rt library.</font></div><div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Tue, May 21, 2013 at 1:31 AM, Daniel Dunbar <span dir="ltr"><<a href="mailto:daniel@zuster.org" target="_blank">daniel@zuster.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hi Alexey,<div><br></div><div>Ancient history, I know, but can explain your motivation for this patch?</div>
<div><br></div><div>I'm asking because this implicitly removes all knowledge of the atomic functions from the Make based build system, so platform specific libraries can't currently opt-in to including the atomic functionality.</div>
<div><br></div><div>I can invent a new feature that allows the builtin module to exclude certain functions from the "CommonFunctions" list, but I'd like to avoid inventing that unless it is really necessary.</div>
<div><br></div><div> - Daniel</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Apr 12, 2012 at 2:43 AM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: samsonov<br>
Date: Thu Apr 12 04:43:57 2012<br>
New Revision: 154583<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=154583&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=154583&view=rev</a><br>
Log:<br>
Don't build atomic.c when building compiler-rt using make<br>
<br>
Modified:<br>
compiler-rt/trunk/lib/Makefile.mk<br>
<br>
Modified: compiler-rt/trunk/lib/Makefile.mk<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/Makefile.mk?rev=154583&r1=154582&r2=154583&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/Makefile.mk?rev=154583&r1=154582&r2=154583&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/Makefile.mk (original)<br>
+++ compiler-rt/trunk/lib/Makefile.mk Thu Apr 12 04:43:57 2012<br>
@@ -17,8 +17,13 @@<br>
SubDirs += asan<br>
SubDirs += profile<br>
<br>
+# FIXME: We don't currently support building an atomic library, and as it must<br>
+# be a separate library from the runtime library, we need to remove its source<br>
+# code from the source files list.<br>
+ExcludedSources := atomic.c<br>
+<br>
# Define the variables for this specific directory.<br>
-Sources := $(foreach file,$(wildcard $(Dir)/*.c),$(notdir $(file)))<br>
+Sources := $(foreach file,$(wildcard $(Dir)/*.c),$(filter-out $(ExcludedSources),$(notdir $(file))))<br>
ObjNames := $(Sources:%.c=%.o)<br>
Implementation := Generic<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div>Alexey Samsonov, MSK</div>
</font></span></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div></div>