<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Ping?<div><br><div><div>On May 18, 2013, at 5:30 PM, Michael Gottesman <<a href="mailto:mgottesman@apple.com">mgottesman@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">(Sorry there is a typo therein. When I say lowering is done for all 4 types for ResNo == 1 I meant for ResNo == 0 and ResNo == 1).<br><br>Michael<br><br>On May 18, 2013, at 5:26 PM, Michael Gottesman <<a href="mailto:mgottesman@apple.com">mgottesman@apple.com</a>> wrote:<br><br><blockquote type="cite"><br>On May 18, 2013, at 2:22 AM, Duncan Sands <<a href="mailto:duncan.sands@gmail.com">duncan.sands@gmail.com</a>> wrote:<br><br><blockquote type="cite">Hi Michael,<br><br>On 17/05/13 23:33, Michael Gottesman wrote:<br><blockquote type="cite">Hows this look Duncan/Sean?<br></blockquote><br>returning SDValue() in PromoteIntRes_ADDSUBC is not valid. There is no default<br>method that can be fallen back to. If you don't want to handle the ResNo != 1<br>case then you must assert/fail, not just return SDValue().<br><br>Ciao, Duncan.<br></blockquote><br>Hey Duncan,<br><br>In the updated patch are the changes that you requested (i.e. I am not just returning SDValue() in said patch). The lowering is done for all 4 types for ResNo == 1. I should have said something in the email enclosing the updated patch. My apologies for not being clearer.<br><br>Michael<br><br><blockquote type="cite"><br><blockquote type="cite"><br><br><br><br>Michael<br><br>On May 16, 2013, at 10:41 AM, Michael Gottesman <<a href="mailto:mgottesman@apple.com">mgottesman@apple.com</a><br><<a href="mailto:mgottesman@apple.com">mailto:mgottesman@apple.com</a>>> wrote:<br><br><blockquote type="cite">I am trying to be incremental and did not have a need for such lowering. On<br>the other hand if you want I can implement that in this patch. Just state your<br>preference = ).<br><br>Michael<br><br>On May 16, 2013, at 1:34 AM, Duncan Sands <<a href="mailto:duncan.sands@gmail.com">duncan.sands@gmail.com</a><br><<a href="mailto:duncan.sands@gmail.com">mailto:duncan.sands@gmail.com</a>>> wrote:<br><br><blockquote type="cite">Hi Michael,<br><br>On 15/05/13 19:37, Michael Gottesman wrote:<br><blockquote type="cite">The attached patch teaches selection DAG how to promote the integer carry<br>result of an {add,sub}{c,e} node to a larger integer type. It is a part of a<br>larger set of patches that I will be committing over the next little bit to<br>enable the optimization of uaddo/usubo chains.<br><br>Please Review,<br>Michael<br></blockquote><br>+SDValue DAGTypeLegalizer::PromoteIntRes_ADDSUBC(SDNode *N, unsigned ResNo) {<br>+ if (ResNo == 1)<br>+ return PromoteIntRes_Overflow(N);<br>+ return SDValue();<br>+}<br>+<br>+SDValue DAGTypeLegalizer::PromoteIntRes_ADDSUBE(SDNode *N, unsigned ResNo) {<br>+ if (ResNo == 1)<br>+ return PromoteIntRes_Overflow(N);<br>+ return SDValue();<br>+}<br><br>why do you return SDValue() if ResNo != 1 ? Shouldn't you either assert or<br>promote the value?<br><br>Ciao, Duncan.<br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a> <<a href="mailto:llvm-commits@cs.uiuc.edu">mailto:llvm-commits@cs.uiuc.edu</a>><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></blockquote><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a> <<a href="mailto:llvm-commits@cs.uiuc.edu">mailto:llvm-commits@cs.uiuc.edu</a>><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></blockquote><br></blockquote><br></blockquote><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></body></html>