<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Minor nit picking. Can you add a string to the new assertion that you added ? LGTM. <div><br><div><div>On May 15, 2013, at 2:04 PM, David Majnemer <<a href="mailto:david.majnemer@gmail.com">david.majnemer@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr">This patch has been updated to handle sbb and adc.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, May 13, 2013 at 12:05 AM, David Majnemer<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div dir="ltr">This patch enhances the existing isDefConvertible logic to include support for more instructions like SHL/SHR/SAL. Tests are included.</div></blockquote></div><br></div><span><Mail Attachment></span></div></blockquote></div><br></div></body></html>