<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">On May 15, 2013, at 2:04 PM, Owen Anderson <<a href="mailto:resistor@mac.com">resistor@mac.com</a>> wrote:<br><div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">LGTM, with two comments:<br><br><blockquote type="cite">- SDValue Ops[] = { N->getOperand(0), N->getOperand(1) };<br>+ const unsigned NumOperands = N->getNumOperands();<br>+ SDValue Ops[3] = { N->getOperand(0), N->getOperand(1) };<br>+ if (NumOperands == 3)<br>+ Ops[2] = N->getOperand(2);<br></blockquote><br>It took me a while to figure out what case this was handling. Perhaps it merits a comment?<br></div></blockquote><div><br></div><div>I will add it.</div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>Second, is it possible to write a test for this functionality? I know that there are dependent patches incoming, but it would be good to test each patch independently as much as possible.<br></div></blockquote><div><br></div><div>There are no IR intrinsics that lower directly to {add,sub}{c,e} directly. That is the whole point of this stream of patches, so I don't think I can write any tests for this = (.</div><div><br></div><div>So if I add the comment, LGTM?</div><div><br></div><div>Michael</div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>--Owen<br><br>On May 15, 2013, at 10:37 AM, Michael Gottesman <<a href="mailto:mgottesman@apple.com">mgottesman@apple.com</a>> wrote:<br><br><blockquote type="cite">The attached patch teaches selection DAG how to promote the integer carry result of an {add,sub}{c,e} node to a larger integer type. It is a part of a larger set of patches that I will be committing over the next little bit to enable the optimization of uaddo/usubo chains.<br><br>Please Review,<br>Michael<br><br><0001-Teach-SelectionDAG-how-to-promote-the-integer-carry-.patch><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</blockquote></div></blockquote></div><br></body></html>