<p dir="ltr"><br>
On May 1, 2013 8:01 AM, "Peng Cheng" <<a href="mailto:gm4cheng@gmail.com">gm4cheng@gmail.com</a>> wrote:<br>
><br>
> Author: chp<br>
> Date: Wed May  1 10:00:07 2013<br>
> New Revision: 180851<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=180851&view=rev">http://llvm.org/viewvc/llvm-project?rev=180851&view=rev</a><br>
> Log:<br>
> get rid of windows warning:<br>
><br>
> warning C4800: forcing value to bool 'true' or 'false' (performance warning)</p>
<p dir="ltr">This warning is, in my opinion/experience, particularly unhelpful. Can we just disable it instead?</p>
<p dir="ltr">><br>
> Modified:<br>
>     llvm/trunk/include/llvm/IR/DerivedTypes.h<br>
><br>
> Modified: llvm/trunk/include/llvm/IR/DerivedTypes.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DerivedTypes.h?rev=180851&r1=180850&r2=180851&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DerivedTypes.h?rev=180851&r1=180850&r2=180851&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/include/llvm/IR/DerivedTypes.h (original)<br>
> +++ llvm/trunk/include/llvm/IR/DerivedTypes.h Wed May  1 10:00:07 2013<br>
> @@ -117,7 +117,7 @@ public:<br>
>    /// argument type.<br>
>    static bool isValidArgumentType(Type *ArgTy);<br>
><br>
> -  bool isVarArg() const { return getSubclassData(); }<br>
> +  bool isVarArg() const { return getSubclassData()!=0; }<br>
>    Type *getReturnType() const { return ContainedTys[0]; }<br>
><br>
>    typedef Type::subtype_iterator param_iterator;<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>