<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">LGTM. <div><br></div><div><br><div><div>On Apr 30, 2013, at 7:59 PM, "Magee, Joshua" <<a href="mailto:Joshua_Magee@playstation.sony.com">Joshua_Magee@playstation.sony.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hi,<br><br>In our private tree we had a change to fix the assembly string for the<br>VMOVPQIto64rr instruction (it lacked the 'v' prefix). This was fixed in the<br>public tree at svn r162963 by adding a 'v' to the assembly string. Our private<br>fix was a bit different: I changed the instruction class from the basic 'I'<br>class to the more specialized 'VRPDI' class.<br><br>While both fixes are functionally equivalent, I think my fix of using VRPDI is<br>more consistent with many other related instruction definitions.<br><br>Looking back through the version history, VMOVPQIto64rr previously used the VRPDI<br>instruction class until r140098. That commit fixed PR10949 by using a generic<br>instruction class and then explicitly listing all the required flags (VEX,<br>VEX_W, etc). While that worked, it was overkill; all that was needed was to<br>add the VEX flag to the instruction.<br><br><br>Attached is a patch against TOT which uses VRPDI. It is functionally<br>equivalent to the current code but more consistent with the way other related<br>instructions are defined.<br><br>This is a very minor issue, but I had the patch anyway so I figured I might as well<br>mention it.<br><br>Thanks,<br>Josh<br><span><vmovd.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></body></html>