<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Committed r<span style="font-family: Menlo; font-size: 11px;">180617.</span><div><font face="Menlo"><span style="font-size: 11px;"><br></span></font><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div><div>On Apr 26, 2013, at 3:28 AM, Mihail Popa <<a href="mailto:mihail.popa@gmail.com">mihail.popa@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr">Quentin,<div><br></div><div>I have updated the tests. Please commit this for me.</div><div>Don't forget to svn add test/MC/Disassembler/ARM/invalid-hint-arm.txt test/MC/Disassembler/ARM/invalid-hint-thumb.txt test/MC/ARM/invalid-hint-thumb.s test/MC/ARM/invalid-hint-arm.s</div><div><br></div><div>Thanks,</div><div>Mihai</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Apr 25, 2013 at 6:12 PM, Quentin Colombet<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:qcolombet@apple.com" target="_blank">qcolombet@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;">Hi Mihail,<div><br></div><div>You shouldn’t set the -disassemble option for your .s tests.</div><div>Other than that, LGTM.</div><div><br></div><div>Thanks,</div><div><br><div><div style="text-indent: 0px; letter-spacing: normal; font-variant: normal; text-align: -webkit-auto; font-style: normal; font-weight: normal; line-height: normal; text-transform: none; font-size: medium; white-space: normal; font-family: Helvetica; word-wrap: break-word; word-spacing: 0px;">-Quentin</div></div><br><div><div><div class="h5"><div>On Apr 25, 2013, at 7:21 AM, Mihail Popa <<a href="mailto:Mihail.Popa@arm.com" target="_blank">Mihail.Popa@arm.com</a>> wrote:</div><br></div></div><blockquote type="cite"><div style="letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;"><div><div class="h5">Hi.<br><br>This is the long delayed follow up patch to the similar issue encountered with ARM encodings. The issue is slightly more complex because the nop-compatible hint space for Thumb actually overlaps the encoding space of the CPS instruction. In actuality, hints can be defined as CPS instructions where imod and M bits are all nil.<br><br>Because tablegen does not support != operator in let expressions, the only tablegen-only solution would be to define multiple instructions, one for each imod setting. This would pollute the td file and bring no real value. Instead I propose that we should handle decoding of permitted nop-compatible hints (i.e. nop, yield, wfi, wfe, sev) in DecodeT2CPSInstruction.<br><br>The patch also adds a proper diagnostic message for Imm0_4 and updates all tests. Please note that this patch contains new files! The person who will commit must to a svn add for these first!.<br><br>Thanks,<br></div></div>Mihai<span><LLVM-722.thumb_hints.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></div><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br><br></blockquote></div><br></div><span><LLVM-722.thumb_hints.patch></span></div></blockquote></div><br></div></body></html>