<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">On Apr 24, 2013, at 5:04 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:<br><div><div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Testcase and description? That's really not much of a commit message.<br></div></blockquote><div><br></div><div>Hopefully, r180445 clarifies a few things.</div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">There's also no corresponding front end commit to diagnose this.<br>What's up here?<br></div></blockquote><div><br></div><div>Now that you have a better description is this something that can be easily diagnosed in the frontend?</div><div><br></div><div> Chad</div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>-eric<br><br>On Wed, Apr 24, 2013 at 11:53 PM, Chad Rosier <<a href="mailto:mcrosier@apple.com">mcrosier@apple.com</a>> wrote:<br><blockquote type="cite">Author: mcrosier<br>Date: Wed Apr 24 17:53:10 2013<br>New Revision: 180226<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=180226&view=rev">http://llvm.org/viewvc/llvm-project?rev=180226&view=rev</a><br>Log:<br>[inline asm] Fix a crasher for an invalid value type/register class.<br><a href="rdar://13731657">rdar://13731657</a><br><br>Modified:<br> llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp<br><br>Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp<br>URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp?rev=180226&r1=180225&r2=180226&view=diff<br>==============================================================================<br>--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (original)<br>+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp Wed Apr 24 17:53:10 2013<br>@@ -6171,10 +6171,17 @@ void SelectionDAGBuilder::visitInlineAsm<br> MatchedRegs.RegVTs.push_back(RegVT);<br> MachineRegisterInfo &RegInfo = DAG.getMachineFunction().getRegInfo();<br> for (unsigned i = 0, e = InlineAsm::getNumOperandRegisters(OpFlag);<br>- i != e; ++i)<br>- MatchedRegs.Regs.push_back<br>- (RegInfo.createVirtualRegister(TLI.getRegClassFor(RegVT)));<br>-<br>+ i != e; ++i) {<br>+ if (const TargetRegisterClass *RC = TLI.getRegClassFor(RegVT))<br>+ MatchedRegs.Regs.push_back(RegInfo.createVirtualRegister(RC));<br>+ else {<br>+ LLVMContext &Ctx = *DAG.getContext();<br>+ Ctx.emitError(CS.getInstruction(), "inline asm error: This value"<br>+ " type register class is not natively supported!");<br>+ report_fatal_error("inline asm error: This value type register "<br>+ "class is not natively supported!");<br>+ }<br>+ }<br> // Use the produced MatchedRegs object to<br> MatchedRegs.getCopyToRegs(InOperandVal, DAG, getCurDebugLoc(),<br> Chain, &Flag, CS.getInstruction());<br><br><br>_______________________________________________<br>llvm-commits mailing list<br>llvm-commits@cs.uiuc.edu<br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</blockquote></div></blockquote></div><br></div></body></html>