<div dir="ltr">Ah, sure. </div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Apr 24, 2013 at 3:47 AM, Evgeniy Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">By "result" I mean the pointer itself, not the allocated memory.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Wed, Apr 24, 2013 at 3:53 AM, Kostya Serebryany <<a href="mailto:kcc@google.com">kcc@google.com</a>> wrote:<br>
> Why?<br>
><br>
><br>
> On Tue, Apr 23, 2013 at 6:27 AM, Evgeniy Stepanov<br>
> <<a href="mailto:eugeni.stepanov@gmail.com">eugeni.stepanov@gmail.com</a>> wrote:<br>
>><br>
>> Author: eugenis<br>
>> Date: Tue Apr 23 08:27:36 2013<br>
>> New Revision: 180101<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=180101&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=180101&view=rev</a><br>
>> Log:<br>
>> [msan] Unpoison the result of posix_memalign.<br>
>><br>
>> Modified:<br>
>>     compiler-rt/trunk/lib/msan/msan_interceptors.cc<br>
>>     compiler-rt/trunk/lib/msan/tests/msan_test.cc<br>
>><br>
>> Modified: compiler-rt/trunk/lib/msan/msan_interceptors.cc<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/msan/msan_interceptors.cc?rev=180101&r1=180100&r2=180101&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/msan/msan_interceptors.cc?rev=180101&r1=180100&r2=180101&view=diff</a><br>

>><br>
>> ==============================================================================<br>
>> --- compiler-rt/trunk/lib/msan/msan_interceptors.cc (original)<br>
>> +++ compiler-rt/trunk/lib/msan/msan_interceptors.cc Tue Apr 23 08:27:36<br>
>> 2013<br>
>> @@ -114,8 +114,10 @@ INTERCEPTOR(void *, memset, void *s, int<br>
>>  INTERCEPTOR(int, posix_memalign, void **memptr, SIZE_T alignment, SIZE_T<br>
>> size) {<br>
>>    GET_MALLOC_STACK_TRACE;<br>
>>    CHECK_EQ(alignment & (alignment - 1), 0);<br>
>> -  *memptr = MsanReallocate(&stack, 0, size, alignment, false);<br>
>>    CHECK_NE(memptr, 0);<br>
>> +  *memptr = MsanReallocate(&stack, 0, size, alignment, false);<br>
>> +  CHECK_NE(*memptr, 0);<br>
>> +  __msan_unpoison(memptr, sizeof(*memptr));<br>
>>    return 0;<br>
>>  }<br>
>><br>
>><br>
>> Modified: compiler-rt/trunk/lib/msan/tests/msan_test.cc<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/msan/tests/msan_test.cc?rev=180101&r1=180100&r2=180101&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/msan/tests/msan_test.cc?rev=180101&r1=180100&r2=180101&view=diff</a><br>

>><br>
>> ==============================================================================<br>
>> --- compiler-rt/trunk/lib/msan/tests/msan_test.cc (original)<br>
>> +++ compiler-rt/trunk/lib/msan/tests/msan_test.cc Tue Apr 23 08:27:36 2013<br>
>> @@ -1627,6 +1627,15 @@ TEST(MemorySanitizer, PreAllocatedStackT<br>
>>    ASSERT_EQ(0, res);<br>
>>  }<br>
>><br>
>> +TEST(MemorySanitizer, posix_memalign) {<br>
>> +  void *p;<br>
>> +  EXPECT_POISONED(p);<br>
>> +  int res = posix_memalign(&p, 4096, 13);<br>
>> +  ASSERT_EQ(0, res);<br>
>> +  EXPECT_NOT_POISONED(p);<br>
>> +  free(p);<br>
>> +}<br>
>> +<br>
>>  TEST(MemorySanitizer, uname) {<br>
>>    struct utsname u;<br>
>>    int res = uname(&u);<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
</div></div></blockquote></div><br></div>