<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Apr 22, 2013, at 3:17 PM, Benjamin Kramer <<a href="mailto:benny.kra@gmail.com">benny.kra@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>On 22.04.2013, at 22:42, Chad Rosier <<a href="mailto:mcrosier@apple.com">mcrosier@apple.com</a>> wrote:<br><br><blockquote type="cite">Author: mcrosier<br>Date: Mon Apr 22 15:42:32 2013<br>New Revision: 180044<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=180044&view=rev">http://llvm.org/viewvc/llvm-project?rev=180044&view=rev</a><br>Log:<br>Fix unused variable warning.<br><br>Modified:<br> llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp<br><br>Modified: llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp?rev=180044&r1=180043&r2=180044&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp?rev=180044&r1=180043&r2=180044&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp (original)<br>+++ llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp Mon Apr 22 15:42:32 2013<br>@@ -1130,7 +1130,7 @@ X86AsmParser::CreateMemForInlineAsm(unsi<br> InlineAsmIdentifierInfo &Info){<br><br><br>- if (const MCSymbolRefExpr *SymRef = dyn_cast<MCSymbolRefExpr>(Disp)) {<br>+ if (Disp && isa<MCSymbolRefExpr>(Disp)) {<br></blockquote><br>dyn_cast doesn't allow NULLs, so you probably don't have to check if Disp is NULL here.<br></div></blockquote><div><br></div><div>You are correct. Committed revision 180059. Thanks, Ben.</div><div><br></div><div> Chad</div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>- Ben<br><br><blockquote type="cite"> // If this is not a VarDecl then assume it is a FuncDecl or some other label<br> // reference. We need an 'r' constraint here, so we need to create register<br> // operand to ensure proper matching. Just pick a GPR based on the size of<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</blockquote></div></blockquote></div><br></body></html>