<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">LGTM. <div><br><div><div>On Apr 17, 2013, at 5:10 PM, Jim Stichnoth <<a href="mailto:stichnot@google.com">stichnot@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr"><span style="font-family: arial, sans-serif; font-size: 13px;">In X86FastISel::</span><span style="font-family: arial, sans-serif; font-size: 13px;">X86SelectStore(), improperly aligned stores are rejected and handled by the DAG-based ISel. However, X86FastISel::</span><span style="font-family: arial, sans-serif; font-size: 13px;">X86SelectLoad() makes no such requirement. There doesn't appear to be an x86 architectural correctness issue with allowing potentially unaligned store instructions.</span><br><div><span style="font-family: arial, sans-serif; font-size: 13px;"><br></span></div><div><span style="font-family: arial, sans-serif; font-size: 13px;">The attached patch removes this restriction.</span></div><div><span style="font-family: arial, sans-serif; font-size: 13px;"><br></span></div><div><span style="font-family: arial, sans-serif; font-size: 13px;">Jim</span></div></div><span><fastisel_unaligned_store.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></body></html>