<div dir="ltr">Hi folks,<div><br></div><div>It's great to see such interest in ARM EHABI, and I agree with both of you that you should merge all patches into one. Ultimately, Anton is the final approval, since that's his area, so you should always wait for his review.</div>
<div><br></div><div>I'd also suggest that you run the regression test in the test-suite (SingleSource/Regression/C++) by re-enabling EH in the Makefile and running only that test (with --only-test) and seeing what this patch fixes and what not (and why).</div>
<div><br></div><div>I'm not expecting the patch to fix much (especially not everything), but would be good to know how are we progressing, and that would make the patch more trustworthy.</div><div><br></div><div>cheers,</div>
<div>--renato</div><div class="gmail_extra"><br><br><div class="gmail_quote">On 15 April 2013 07:08, WenHan Gu (ÍÛÚ¡ù×) <span dir="ltr"><<a href="mailto:wenhan.gu@gmail.com" target="_blank">wenhan.gu@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi, Cho,<div><br></div><div>Thanks for your response.</div><div>It's important to clarify that I won't insist that who's patch will be accepted, just FYI. :)</div>
<div><br></div>
<div>ARM EHABI has been implemented at most part, and I think functions by this patch should be review asap.</div><div>Maybe you can contact Logan Chien (owner of the other patch) and derive a refined patch, and ask Anton to help review.</div>
<div>More people included makes the result more better, that is just what I want to said.</div><div><br></div><div>Thanks for your working on this!</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra">
<br><br><div class="gmail_quote">
2013/4/15 Ilyong Cho <span dir="ltr"><<a href="mailto:ilyoan@gmail.com" target="_blank">ilyoan@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<p dir="ltr">Thank you for informing me.</p>
<p dir="ltr">I didn't know that there was already a patch about the same issue. And I didn't want to step on anybody's toe.</p>
<p dir="ltr">My opinion about that patch? Great!<br>
I've juat looked the patch and I think it looks good but I found the implementation of that patch is different from gas's. I have a weird use case (hand made ARM assembly with a complex function prologue) that the patch on D414 couldn't cover but gas implementation(and mine) could cover.</p>
<p dir="ltr">But I believe it'll work better with normal situation than mine because it implement .vsave that I fogot to implement :(<br>
</p>
<div class="gmail_quote">2013. 4. 15. ¿ÀÈÄ 1:21¿¡ "WenHan Gu (ÍÛÚ¡ù×)" <<a href="mailto:wenhan.gu@gmail.com" target="_blank">wenhan.gu@gmail.com</a>>´ÔÀÌ ÀÛ¼º:<div><div><br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hi,<div><br></div><div>Actually, ARM EHABI has been patch sumbutted at March.</div><div>However, Anton is too busy to review that.</div><div><br></div><div><a href="http://llvm-reviews.chandlerc.com/D414" target="_blank">http://llvm-reviews.chandlerc.com/D414</a></div>
<div><br></div><div>What do you think on this patch?</div><div>Thanks.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/4/15 ilyong cho <span dir="ltr"><<a href="mailto:ily.cho@samsung.com" target="_blank">ily.cho@samsung.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
<br>
I've just found a bug in this patch and fixed it.<br>
The bug was that the code miscalculated the number of words on EmitHandlerData()<br>
<br>
You can find the fixed patch on attachment and also <a href="http://llvm-reviews.chandlerc.com/D662" target="_blank">http://llvm-reviews.chandlerc.com/D662</a><br>
<br>
Review please.<br>
<br>
ILYONG CHO, <a href="mailto:ilyoan@gmail.com" target="_blank">ilyoan@gmail.com</a><br>
<div><div><br>
<br>
> Hi all,<br>
<br>
> This patch is about implemention of ARM EHABI.<br>
> There are three "Not Implemented" functions on lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp. This patch implements it and .movsp directive.<br>
> This patch based on ARM IHI 0038A and gas implemantation.<br>
<br>
> I'd be appreciative review comments. Patch is available on <a href="http://llvm-reviews.chandlerc.com/D662" target="_blank">http://llvm-reviews.chandlerc.com/D662</a><br>
<br>
> Thanks.<br>
<br>
> ILYONG CHO </div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Best Regards,<div>WenHan Gu (Nowar)</div></div>
</div>
</blockquote></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Best Regards,<div>WenHan Gu (Nowar)</div></div>
</div>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>