<div dir="ltr">It is the moral equivalent of #if defined(FOO) at the IR level, sort of.<div><br></div><div style>Vinod</div><div style><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Mar 30, 2013 at 8:58 AM, Sean Silva <span dir="ltr"><<a href="mailto:silvas@purdue.edu" target="_blank">silvas@purdue.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><span style="font-size:13px;font-family:arial,sans-serif">Could you give a bit more background on the motivation for this? I wasn't able to find any discussion on llvmdev.</span></div>
<div class="im">
<div><span style="font-size:13px;font-family:arial,sans-serif"><br></span></div><div><span style="font-size:13px;font-family:arial,sans-serif">+// This pass replaces occurences of __nvvm_reflect("string") with an</span><br style="font-size:13px;font-family:arial,sans-serif">

<span style="font-size:13px;font-family:arial,sans-serif">+// integer based on -nvvm-reflect-list string=<int> option given to this pass.</span><span style="font-size:13px;font-family:arial,sans-serif"><br>
</span></div><div><span style="font-size:13px;font-family:arial,sans-serif"><br></span></div></div><div><span style="font-size:13px;font-family:arial,sans-serif">Please give an example of usage here.</span></div>
<div><span style="font-size:13px;font-family:arial,sans-serif"><br></span></div><div><span style="font-size:13px;font-family:arial,sans-serif">It also seems that in some places you say "0/1", but in this description you say "<int>". Is any int allowed? Please clarify.</span></div>
<div class="im">
<div><span style="font-size:13px;font-family:arial,sans-serif"><br></span></div><div><span style="font-size:13px;font-family:arial,sans-serif">+    int reflectVal = 0; // The default value is 0</span><span style="font-size:13px;font-family:arial,sans-serif"><br>

</span></div><div><span style="font-size:13px;font-family:arial,sans-serif"><br></span></div></div><div><font color="#000000" face="arial, sans-serif">Please put this information in the top-of-the-file comment.</font></div>

<span style="font-size:13px;font-family:arial,sans-serif"><div class="im"><div><span style="font-size:13px;font-family:arial,sans-serif"><br></span></div><div>+  for (unsigned i = 0, e = ReflectList.size(); i != e; ++i) {<br>

+    //    DEBUG(dbgs() << "Option : "  << ReflectList[i] << std::endl);<span style="font-size:13px;font-family:arial,sans-serif"><br></span></div><div><br></div></div><div class="im"><div>+    reflectArg = reflectArg.substr(0, reflectArg.size() - 1);<br>

+    //    DEBUG(dbgs() << "Arg of _reflect : " << reflectArg << std::endl);<span style="font-size:13px;font-family:arial,sans-serif"><br></span></div><div><br></div></div><div class="im">+  //std::map<std::string, int> VarMap;</div>
</span><br style="font-size:13px;font-family:arial,sans-serif">
<span style="font-size:13px;font-family:arial,sans-serif">+  StringMap<int> VarMap;</span><br><div><span style="font-size:13px;font-family:arial,sans-serif"><br></span></div><div>
<span style="font-size:13px;font-family:arial,sans-serif">Please remove commented-out code.</span></div><div class="im"><div><span style="font-size:13px;font-family:arial,sans-serif"><br></span></div>
<div><span style="font-size:13px;font-family:arial,sans-serif">+static std::vector<std::string></span><br style="font-size:13px;font-family:arial,sans-serif"><span style="font-size:13px;font-family:arial,sans-serif">+Tokenize(const std::string &str, const std::string &delim) {</span><br style="font-size:13px;font-family:arial,sans-serif">

<span style="font-size:13px;font-family:arial,sans-serif">+  std::vector<std::string> tokens;</span><br style="font-size:13px;font-family:arial,sans-serif"><br></div></div><div><font color="#000000" face="arial, sans-serif">Is there a particular reason you aren't following the LLVM naming convention here and throughout?</font></div>
<span class="HOEnZb"><font color="#888888">
<div><font color="#000000" face="arial, sans-serif"><br></font></div><div><font color="#000000" face="arial, sans-serif">-- Sean Silva</font></div></font></span></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>