<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi, Nuno:<br>
<br>
Let me go through the events about your changes. <br>
<br>
1. Your change originally triggered a bug about LTO bootstrap
build. <br>
Bill revert your change and file a bug. <br>
<br>
2. My manager asked me to figure out the root cause. '<br>
I fixed the problem and reiterate (in many places) that your
problematic should be applied with my change. <br>
Unfortunately, you silently let your code creep in without
even a single word addressing my concerns. <br>
<br>
3. Yi Jiang later on realized that your change increase GVN
compile-time by 10%. <br>
You try to "reproduce" with debug-built compiler and claim
you cannot reproduce the problem, <br>
and you claim you are too busy to dig into the problem. (Why
the hack you have time to write <br>
the code in the 1st place?). <br>
<br>
4. Nadav asked you to revert your change, you seems to be
quite reluctant, and ask Nadav to <br>
"judiciously" revert "some code", "not too much". <br>
<br>
This is really ridiculous! I have never heard before that a
original author of the problematic <br>
patch asked other people to "judiciously" revert part of
patch.<br>
<br>
5. Also you promise you bring the comment to "object" back, you
never did!<br>
<br>
It seems it is very difficult to work w you. go back to this
mail. <br>
<br>
> You should not remove getUnderlyingObjectSize(), since it's
required for correctness of BasicAA.<br>
Which bug did you fixed in the 176407? <br>
And, why we cannot remove getUnderlyingObjectSize()?<br>
<br>
In 176407, you just redo I made previously in order to enable your
2nd change. <br>
Check your emails, 176407 was similar to my original proposal,
after discuss with Arnold, <br>
I ditch this proposal, and go for his proposal. <br>
<br>
If you want to revert 176407, you first need to reproduce the
defect Yi report, and convince us with <br>
data you collect. <br>
<br>
<br>
<br>
On 4/13/13 7:55 PM, Nadav Rotem wrote:<br>
</div>
<blockquote
cite="mid:BD557A80-041C-4049-9E07-E64E96254EB6@apple.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<br>
<div>
<div>On Apr 13, 2013, at 6:22 PM, Nuno Lopes <<a
moz-do-not-send="true" href="mailto:nunoplopes@sapo.pt">nunoplopes@sapo.pt</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="letter-spacing: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px;">Hi Nadav,<br>
<br>
I'm sorry to say but you reverted too much. In particular:<br>
- You should not remove getUnderlyingObjectSize(), since
it's required for correctness of BasicAA.<br>
- BasicAA changes shouldn't be reverted for the same reason.<br>
- Tests 18 and 19 have nothing to do with this, and should
stay.<br>
<br>
I can perform these changes myself if you prefer.<br>
<br>
</div>
</blockquote>
<div><br>
</div>
</div>
Hi Nuno,
<div><br>
</div>
<div>Thanks for looking at this. Are you going to re-apply r176407
?</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Nadav</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>