<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Ok good.<div><br></div><div>I didn’t noticed that!</div><div><br><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div><div>On Apr 12, 2013, at 9:48 AM, Mihail Popa <<a href="mailto:Mihail.Popa@arm.com">Mihail.Popa@arm.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hi Quentin.<br><br>It's just (intended) trimming of extra white space at the end of the line.<br><br>Regards,<br>Mihai<br>________________________________________<br>From: Quentin Colombet [<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>]<br>Sent: Friday, April 12, 2013 5:42 PM<br>To: Mihail Popa<br>Cc:<span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>Subject: Re: [PATCH] Correct printing of pre-indexed operands<br><br>Hi Mihai,<br><br>At the very end of your patch it seems you have unintended changes:<br>- << markup("<imm:")<br>+ << markup("<imm:”)<br>and<br>- << markup("<imm:")<br>+ << markup("<imm:")<br><br>Other than that LGTM.<br><br>Thanks<br><br>-Quentin<br><br>On Apr 12, 2013, at 9:29 AM, Mihail Popa <<a href="mailto:Mihail.Popa@arm.com">Mihail.Popa@arm.com</a><<a href="mailto:Mihail.Popa@arm.com">mailto:Mihail.Popa@arm.com</a>>> wrote:<br><br>Hi.<br><br>According to the ARM reference manual, constant offsets are mandatory for pre-indexed addressing modes. Currently the MC disassembler<br>does not obey this when the offset is 0. It produces instructions like: str r0, [r1]!. Correct syntax is: str r0, [r1, #0]!.<br><br>This change modifies the dumping of operands so that the offset is always printed, regardless of its value, when pre-indexed addressing mode<br>is used.<br><br>Patch attached for review.<br><br>Thanks,<br>Mihai<br><br>-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.<LLVM-707.preindex.patch>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><<a href="mailto:llvm-commits@cs.uiuc.edu">mailto:llvm-commits@cs.uiuc.edu</a>><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br><br><br>-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.</div></blockquote></div><br></div></body></html>