<div dir="ltr">On Thu, Apr 11, 2013 at 5:58 PM, Nadav Rotem <span dir="ltr"><<a href="mailto:nrotem@apple.com" target="_blank" class="cremed">nrotem@apple.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">It aligns all blocks to a specific alignment. Do you prefer a different name ?</div></blockquote>
<div><br></div><div style>No, I understand why it is adding alignment, I'm asking why it also returns before actually doing any block layout... For example, this won't fix loop layout or anything else. It will *only* change the alignment.</div>
<div style><br></div><div style>There is already a loop in the block layout code that does some alignment, I would naively expected this flag to be implemented by changing that logic.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><div class="h5"><div><br><div><div>On Apr 11, 2013, at 5:57 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank" class="cremed">chandlerc@google.com</a>> wrote:</div>
<br><blockquote type="cite"><div class="gmail_extra" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
<div class="gmail_quote"><br>On Thu, Apr 11, 2013 at 5:48 PM, Nadav Rotem<span> </span><span dir="ltr"><<a href="mailto:nrotem@apple.com" target="_blank" class="cremed">nrotem@apple.com</a>></span><span> </span>wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div>+  if (AlignAllBlock) {<br>+    // Align all of the blocks in the function to a specific alignment.<br>
+    for (MachineFunction::iterator FI = F.begin(), FE = F.end();<br>+         FI != FE; ++FI)<br>+      FI->setAlignment(AlignAllBlock);<br>+    return true;<br>+  }<br>+<br>   buildCFGChains(F);</div></blockquote></div>
<br><br></div><div class="gmail_extra" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
Huh? This turns of block layout altogether, which seems rather surprising for a flag called "align-all-blocks".</div></blockquote></div><br></div></div></div></div></blockquote></div><br></div></div>