<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Go ahead, I was trying to be helpful if I could be = ).<div><br></div><div>Michael</div><div><br><div><div>On Apr 6, 2013, at 4:47 AM, Renato Golin <<a href="mailto:renato.golin@linaro.org">renato.golin@linaro.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Hi Michael,<div><br></div><div style="">Are you happy that I commit this just to make the tests happy and later on we do a better analysis on the tool?</div><div style=""><br></div><div style="">cheers,</div><div style="">
--renato</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 5 April 2013 01:20, Renato Golin <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="im">On 5 April 2013 00:57, Renato Golin <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><div class="im">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><span style="color:rgb(34,34,34)">I'll share my results once they're done, and while that, the test-suite is running with the new fpcmp.</span></div>
</div></blockquote><div><br></div></div><div>Patch attached. Whole test-suite pass (voronoi still fails, as before, unrelated).</div><div><br></div><div>Some simple extra tests:</div><div><br></div><div>
<div>1.31231312,3</div><div>1.3123131,3</div><div>Old: would compare 1.31231312 with 3 and fail<br></div><div>New, as expected: e-7 pass, e-8 fails</div><div><br></div><div>1231.23123123</div><div>123.123123123</div><div>
Both behave well<br></div><div><br></div><div>421.41414abcdef</div><div>421.4141411abcdef</div><div>Old: FP Comparison failed, not a numeric difference between 'a' and '4'<br></div><div>New, as expected: e-8 pass, e-9 fails</div>
<div><br></div><div>lalala 123foo</div><div>lalala123foo</div><div>Both behave well<br></div><div><br></div><div>31,312.312<br></div><div>31,312.31</div><div>At the end of a file.<br></div><div>Old, as expected, not a numeric difference between '' and '3'<br>
</div><div>New, as expected, reports the error e-6 and beyond</div></div><div><br></div><div>cheers,</div><div>--renato</div><div><br></div></div></div></div>
</blockquote></div><br></div>
</blockquote></div><br></div></body></html>