<div dir="ltr">I don't like DCHECKs -- they cause us to have two build configs. <div style>In tsan we have to, because some parts of the tsan runtime are extremely performance critical.</div><div style>in asan, there is nothing that critical to force us to use DCHECKs. At least I am not convinced. </div>
<div style><br></div><div style>--kcc </div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Mar 29, 2013 at 10:47 AM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote"><div class="im">On Thu, Mar 28, 2013 at 8:38 PM, Alexander Potapenko <span dir="ltr"><<a href="mailto:glider@google.com" target="_blank">glider@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Which configuration enables DCHECKs? Are they enabled on our bots? If<br>
not, they're almost useless and may rot soon.<br></blockquote><div><br></div></div><div>I understand your concern... DCHECK's are enabled in debug TSan builds (which run tests from tsan and sanitizer_common).</div>
<div>But we may extend this to all sanitizer_tools to be safer.</div><div><div class="h5"><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div><br>
On Thu, Mar 28, 2013 at 7:37 PM, Alexey Samsonov <<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>> wrote:<br>
> Author: samsonov<br>
> Date: Thu Mar 28 10:37:11 2013<br>
> New Revision: 178238<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=178238&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=178238&view=rev</a><br>
> Log:<br>
> [Sanitizer] Minor enhancements in InternalVector container<br>
><br>
> Modified:<br>
> compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h<br>
><br>
> Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h?rev=178238&r1=178237&r2=178238&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h?rev=178238&r1=178237&r2=178238&view=diff</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h (original)<br>
> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h Thu Mar 28 10:37:11 2013<br>
> @@ -282,7 +282,11 @@ class InternalVector {<br>
> UnmapOrDie(data_, capacity_ * sizeof(T));<br>
> }<br>
> T &operator[](uptr i) {<br>
> - CHECK_LT(i, size_);<br>
> + DCHECK_LT(i, size_);<br>
> + return data_[i];<br>
> + }<br>
> + const T &operator[](uptr i) const {<br>
> + DCHECK_LT(i, size_);<br>
> return data_[i];<br>
> }<br>
> void push_back(const T &element) {<br>
> @@ -301,7 +305,7 @@ class InternalVector {<br>
> CHECK_GT(size_, 0);<br>
> size_--;<br>
> }<br>
> - uptr size() {<br>
> + uptr size() const {<br>
> return size_;<br>
> }<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
<br>
<br>
</div></div><span><font color="#888888">--<br>
Alexander Potapenko<br>
Software Engineer<br>
Google Moscow<br>
</font></span></blockquote></div></div></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</font></span></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>