You are right. It doesn't need -O3 to trigger the code.<br><br>Fixed in r178278.<br><br><div class="gmail_quote">On Thu, Mar 28, 2013 at 7:35 AM, Tobias Grosser <span dir="ltr"><<a href="mailto:tobias@grosser.es" target="_blank">tobias@grosser.es</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 03/28/2013 02:28 AM, Akira Hatanaka wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
Author: ahatanak<br>
Date: Wed Mar 27 20:28:02 2013<br>
New Revision: 178208<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=178208&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=178208&view=rev</a><br>
Log:<br>
Check if Type is a vector before calling function Type::getVectorNumElements.<br>
Added: llvm/trunk/test/Transforms/<u></u>InstCombine/vector-type.ll<br></div><div class="im">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/vector-type.ll?rev=178208&view=auto" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>Transforms/InstCombine/vector-<u></u>type.ll?rev=178208&view=auto</a><br>

==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/Transforms/<u></u>InstCombine/vector-type.ll (added)<br>
+++ llvm/trunk/test/Transforms/<u></u>InstCombine/vector-type.ll Wed Mar 27 20:28:02 2013<br>
@@ -0,0 +1,15 @@<br>
+;  The code in InstCombiner::FoldSelectOpOp was calling<br>
+;  Type::getVectorNumElements without checking first if the type was a vector.<br>
+<br>
+; RUN: opt < %s -instcombine -S -O3<br>
</div></blockquote>
<br>
Do we really want to run all '-03' passes here? I would prefer to reduce this to the minimal sets of passes necessary.<br>
<br>
Tobi<div class="HOEnZb"><div class="h5"><br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br>