<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Am 26.03.2013 18:58, schrieb Justin
Holewinski:<br>
</div>
<blockquote
cite="mid:CAJgxuadk9-6++4oaRmWAbCb74xwDa7dGNF3y0nV_-k09SpYwjw@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Tue, Mar 26, 2013 at 1:50 PM,
Christian König <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:christian.koenig@amd.com" target="_blank">christian.koenig@amd.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Am <a
moz-do-not-send="true" href="tel:26.03.2013%2018"
value="+12603201318" target="_blank">26.03.2013 18</a>:18,
schrieb Rafael Espíndola:
<div class="im">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
As Michel already wrote in the commit message, it
fixes two piglit tests and<br>
so doesn't need to be covered by any llvm tests.<br>
<br>
While it might make sense for some low level
instructions to be covered by<br>
llvm tests, it probably doesn't make any sense for
complex behavior changes<br>
like this one, since they are covered pretty well by
piglit.<br>
</blockquote>
That is not the case at all! Please check the
developer policy:<br>
<br>
<a moz-do-not-send="true"
href="http://llvm.org/docs/DeveloperPolicy.html#test-cases"
target="_blank">http://llvm.org/docs/DeveloperPolicy.html#test-cases</a><br>
</blockquote>
<br>
</div>
I know the policy, but it still doesn't make much sense
for us covering the same code by two different unit
testing frameworks.<span class="HOEnZb"><font
color="#888888"><br>
<br>
Christian.</font></span></blockquote>
<div><br>
</div>
<div>The issue here is more about non-R600 developers. If I
modify shared codegen code somewhere, I want some way of
verifying that I haven't broken your change. That's the
purpose of running the unit tests pre-commit. These tests
have to be in-tree, and I certainly don't want to have to
run mesa tests as a pre-commit check for LLVM!<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Completely agree to that, and I think adding test cases for new
patterns, instructions important backend behaviour etc.. does indeed
make allot of sense.<br>
<br>
But for example for the last change of our ELSE pseudo operation I
don't even know how to cover that with llvm IR (except for adding
compiled IR output of piglit and that's something around 25kb in
size and covering allot of different things and not only that bug in
specific).<br>
<br>
Well I can easily make an IR dump of all falling/fixed piglit tests
and that to the repository, but that probably wouldn't be welcome
either.<br>
<br>
Christian.<br>
<br>
<blockquote
cite="mid:CAJgxuadk9-6++4oaRmWAbCb74xwDa7dGNF3y0nV_-k09SpYwjw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>
</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb">
<div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Christian.<br>
<br>
</blockquote>
Cheers,<br>
Rafael<br>
<br>
</blockquote>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu"
target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
<br>
<div>Thanks,</div>
<div><br>
</div>
<div>Justin Holewinski</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>