<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Mon, Mar 25, 2013 at 4:58 PM, Dmitry Vyukov <span dir="ltr"><<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dvyukov<br>
Date: Mon Mar 25 07:58:09 2013<br>
New Revision: 177864<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=177864&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=177864&view=rev</a><br>
Log:<br>
asan/tsan: add Printf/Report hook<br>
The hook can be overriden in frontend to print to e.g. a file.<br>
<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cc?rev=177864&r1=177863&r2=177864&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cc?rev=177864&r1=177863&r2=177864&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cc Mon Mar 25 07:58:09 2013<br>
@@ -173,6 +173,21 @@ void SetPrintfAndReportCallback(void (*c<br>
   PrintfAndReportCallback = callback;<br>
 }<br>
<br>
+// Can be overriden in frontend.<br>
+#ifndef SANITIZER_GO<br>
+SANITIZER_INTERFACE_ATTRIBUTE void WEAK OnPrint(const char *str) {<br>
+  (void)str;<br>
+}<br>
+#endif<br></blockquote><div><br></div><div style>Why not SANITIZER_SUPPORTS_WEAK_HOOKS (we have it in sanitizer_internal_defs.h)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

+<br>
+static void CallPrintfAndReportCallback(const char *str) {<br>
+#ifndef SANITIZER_GO<br>
+  OnPrint(str);<br>
+#endif<br>
+  if (PrintfAndReportCallback)<br>
+    PrintfAndReportCallback(str);<br>
+}<br>
+<br>
 void Printf(const char *format, ...) {<br>
   const int kLen = 16 * 1024;<br>
   InternalScopedBuffer<char> buffer(kLen);<br>
@@ -182,8 +197,7 @@ void Printf(const char *format, ...) {<br>
   va_end(args);<br>
   RAW_CHECK_MSG(needed_length < kLen, "Buffer in Printf is too short!\n");<br>
   RawWrite(buffer.data());<br>
-  if (PrintfAndReportCallback)<br>
-    PrintfAndReportCallback(buffer.data());<br>
+  CallPrintfAndReportCallback(buffer.data());<br>
 }<br>
<br>
 // Writes at most "length" symbols to "buffer" (including trailing '\0').<br>
@@ -238,8 +252,7 @@ void Report(const char *format, ...) {<br>
       }<br>
     } else {<br>
       RawWrite(buffer);<br>
-      if (PrintfAndReportCallback)<br>
-        PrintfAndReportCallback(buffer);<br>
+      CallPrintfAndReportCallback(buffer);<br>
       // Don't do anything for the second time if the first iteration<br>
       // succeeded.<br>
       break;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div></div>