<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Mar 23, 2013, at 10:07 PM, Michael Liao <<a href="mailto:michael.liao@intel.com">michael.liao@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hi All<br><br>On Sandybridge, unaligned 256-bit vector memory access needs splitting<br>to avoid higher cache line split penalty. The 1st patch enhances ToT to<br>handle non <4 x i64> vector integer types. </div></blockquote><div><br></div><div>You are moving comments and definitions around and it makes it difficult to review the code. </div><div><br></div><div>For the first patch, the "if (Op->getOpcode == BITCAST)" line looks okay, but why did you have to move the code that handles concat vectors ?</div><div><br></div><div>Regarding the second patch, this change introduces a bug if the alignment is zero. </div><div><br></div><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">The 2nd patch fixes two<br>alignment calculation issues in ToT. One is a memory access is regarded<br>as aligned if the specified alignment is larger than the natural<br>alignment; the other issue is that the alignment for the high 128-bit<br>vector should be min(16, original alignment) since the pointer is<br>advanced by 16B, a power-of-2 offset.<br><br>Test cases are included for each patch.<br><br>Thanks for review<br>- Michael<br><br><span><0001-Enhance-folding-of-extract_subvec-insert_subvec-V1-V.patch></span><span><0002-Revise-alignment-calculation-issues-on-256-bit-unali.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></body></html>