<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Mar 20, 2013, at 10:54 AM, Eli Bendersky <<a href="mailto:eliben@google.com">eliben@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">On Wed, Mar 20, 2013 at 10:53 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Wed, Mar 20, 2013 at 8:39 AM, Eli Bendersky <<a href="mailto:eliben@google.com">eliben@google.com</a>> wrote:<br>
> On Tue, Mar 19, 2013 at 5:59 PM, Nadav Rotem <<a href="mailto:nrotem@apple.com">nrotem@apple.com</a>> wrote:<br>
>> Hi Eli,<br>
>><br>
>> The timer code LGTM. Why do we need an additional command line flag ?<br>
>><br>
>> Nadav<br>
>><br>
><br>
> time-passes is defined in PassManager so we'd have to make IRReader<br>
> aware of that, which is a layering violation. In addition, many LLVM<br>
> tools use IRReader but don't link PassManager in.<br>
<br>
</div></div>Could we put it somewhere more common?<br></blockquote><div><br></div><div style="">I'm not sure what you mean. Suggestions welcome.</div></div></div></div></blockquote><br></div><div>I don't pretend to understand the layering rules. But how can someone use IRReader without linking LLVMCore? I'm not even sure why IRReader is in Support given that it needs a context. Would there be a problem declaring EnableTimer (or whatever) in LLVMContext.h? If that's a problem (unable to link w/ just LLVMSupport), then you could make it a field in the LLVMContext object instead.</div><div><br></div><div>-Andy</div><br></body></html>