<div dir="ltr">On Tue, Mar 19, 2013 at 8:05 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Tue, Mar 19, 2013 at 8:33 AM, Alexey Samsonov <<a href="mailto:samsonov@google.com">samsonov@google.com</a>> wrote:<br>

> Author: samsonov<br>
> Date: Tue Mar 19 10:33:18 2013<br>
> New Revision: 177409<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=177409&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=177409&view=rev</a><br>
> Log:<br>
> Fix for r177390: map values are pointers, use DeleteContainerSeconds() instead of .clear()<br>
<br>
</div>Pony request: could we just move tools like this to build as C++11<br>
always & then use an owning smart pointer in the container here<br>
instead?<br></blockquote><div><br></div><div style>Do you mean std::shared_ptr?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">

><br>
> Modified:<br>
>     llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.cpp<br>
><br>
> Modified: llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.cpp?rev=177409&r1=177408&r2=177409&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.cpp?rev=177409&r1=177408&r2=177409&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.cpp (original)<br>
> +++ llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.cpp Tue Mar 19 10:33:18 2013<br>
> @@ -12,6 +12,7 @@<br>
>  //===----------------------------------------------------------------------===//<br>
><br>
>  #include "LLVMSymbolize.h"<br>
> +#include "llvm/ADT/STLExtras.h"<br>
>  #include "llvm/Object/MachO.h"<br>
>  #include "llvm/Support/Casting.h"<br>
>  #include "llvm/Support/Path.h"<br>
> @@ -187,7 +188,7 @@ std::string LLVMSymbolizer::symbolizeDat<br>
>  }<br>
><br>
>  void LLVMSymbolizer::flush() {<br>
> -  Modules.clear();<br>
> +  DeleteContainerSeconds(Modules);<br>
>  }<br>
><br>
>  // Returns true if the object endianness is known.<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div></div>